Skip to content

Streamline openssl3 changes #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
fcc5470
Intial squashed work in progress
timlegge Apr 29, 2024
07e2a94
Fix the get_public_key_string to encode the key in the old format
timlegge May 4, 2024
2277304
Replace deprecated MD5 and RIPEMD160 calls
timlegge May 4, 2024
52a00fc
Cleanup the error messaging use Module's style
timlegge May 4, 2024
7020724
Fix the exponent not being set
timlegge May 4, 2024
254d653
Fix missing check key that caused two test failures in bigone.t
timlegge May 5, 2024
13dd92c
Also need to create key when p and q are not provided
timlegge May 5, 2024
8c2bb32
Fix final issue with bignum tests
timlegge May 5, 2024
3e78af7
Fix issue in crufty old version
timlegge May 5, 2024
9d1feb0
Fix issue with openssl < 0x00908000L
timlegge May 5, 2024
d4773c3
Line breaks in #if ... requires ExtUtils::[email protected] possibly 3.48
timlegge May 5, 2024
0c35c8c
Try outputting the openssl version
timlegge May 5, 2024
c1b3a19
Fix differences in signedness
timlegge May 5, 2024
0733855
Check to see if issue is with ripemd160
timlegge May 5, 2024
84cf85d
Fix some additional warnings and stray character before BN_free
timlegge May 5, 2024
9fe4814
Remove unused variable
timlegge May 5, 2024
42af6bc
Collapse duplicate code by passing init function definition
timlegge May 5, 2024
4d34275
Fix memory leak
timlegge May 31, 2024
61367c9
Remove commented out debugging code
timlegge May 31, 2024
16dbfe6
Fix some signedness issues on early openssl
timlegge Jul 2, 2024
76e6e3b
Fixes #48 - Whirlpool is missing the header
timlegge Jul 2, 2024
bacba6d
Fixes #50 - Correct openssl version may not be found
timlegge Jul 3, 2024
a441b56
Fixes #52 - Out of memory on openssl 1.1.1w hpux
timlegge Jul 4, 2024
fd7be1d
Fix issue freeing memory on threaded perl
timlegge Jul 6, 2024
661c253
Move err: after last time it is invoked and only get there if make_rs…
timlegge Jul 7, 2024
5be8a4b
Fix bug private versus public - maybe
timlegge Jul 9, 2024
ed3e25c
Consolidate AIX and HPUX fixes for linking properly
timlegge Jul 20, 2024
2d6d277
Attempt to streamline the changes
timlegge Jul 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions Makefile.PL
Original file line number Diff line number Diff line change
@@ -1,13 +1,35 @@
use strict;
use warnings;
use Config;
use List::Util 1.45 qw(uniq);

use 5.006;
use ExtUtils::MakeMaker 6.48;
use Crypt::OpenSSL::Guess qw(openssl_inc_paths openssl_lib_paths);
use Crypt::OpenSSL::Guess qw(openssl_inc_paths openssl_lib_paths openssl_version);

my ($major, $minor, $patch) = openssl_version();
print "OpenSSL version: $major.$minor $patch", "\n";
# See lib/ExtUtils/MakeMaker.pm for details of how to influence
# the contents of the Makefile that is written.

my $libs = ' -lssl -lcrypto';
if ( $Config{osname} eq 'aix' ) {
$libs = $libs . ' -lz';
}

my $ssllibpth = openssl_lib_paths();
my $lddlflags = $Config{lddlflags};
$lddlflags =~ s/(?=-L)/$ssllibpth /;

my $ldflags = $Config{ldflags};
$ldflags =~ s/(?=-L)/$ssllibpth /;

if ($^O eq "hpux" && $Config{ld} eq "/usr/bin/ld") {
my $bpth = join ":" => uniq (+("$ssllibpth $lddlflags $ldflags") =~ m/-L(\S+)/g);
$lddlflags .= " +b $bpth";
$ldflags .= " +Wl,+b,$bpth";
}

WriteMakefile(
'NAME' => 'Crypt::OpenSSL::RSA',
'AUTHOR' => 'Ian Robertson <[email protected]>',
Expand All @@ -22,7 +44,9 @@ WriteMakefile(
'Test::More' => 0,
},
'OBJECT' => 'RSA.o',
'LIBS' => [openssl_lib_paths() . ' -lssl -lcrypto'],
'LIBS' => [ openssl_lib_paths() . $libs ],
'LDDLFLAGS' => $lddlflags,
'LDFLAGS' => $ldflags,
'DEFINE' => '-DPERL5 -DOPENSSL_NO_KRB5',

# perl-5.8/gcc-3.2 needs -DPERL5, and redhat9 likes -DOPENSSL_NO_KRB5
Expand Down
Loading