Streamline openssl3 changes #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timlegge
force-pushed
the
streamline-openssl3
branch
2 times, most recently
from
58f457d to
b5fe213
Compare
timlegge
force-pushed
the
streamline-openssl3
branch
from
b5fe213 to
2d6d277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @toddr
this is essentially the same functionality with a lot of the #if OPENSSL_VERSION... replaced by some macros at the top. This should be a lot easier to review but I am not sure whether it is the best approach. It is definitely the simplest to review. I think I have reduced it as much as I can - someone with more knowledge of C macros may be able to do something for some of the other #if #else #endif sections.
I am good with either approach
Tim