Skip to content

feat(snowflake)!: Annotate type for VAR_POP, VAR_SAMP, DuckDB consistency fix for VAR_SAMP #6488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VaggelisD merged 9 commits into from
Dec 10, 2025
Merged

feat(snowflake)!: Annotate type for VAR_POP, VAR_SAMP, DuckDB consistency fix for VAR_SAMP #6488

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1b7d708
annotate type for VAR_POP, VAR_SAMP
fivetran-kwoodbeck Dec 4, 2025
fc2f186
update
fivetran-kwoodbeck Dec 5, 2025
594631f
Merge remote-tracking branch 'origin/main' into feature/annotatetype-…
fivetran-kwoodbeck Dec 8, 2025
f435ae2
updated as per PR, made custom annotation function for variance
fivetran-kwoodbeck Dec 8, 2025
7d7d75b
updates as per PR
fivetran-kwoodbeck Dec 9, 2025
e8a908d
Merge remote-tracking branch 'origin/main' into feature/annotatetype-…
fivetran-kwoodbeck Dec 9, 2025
e1eef10
updates as per PR
fivetran-kwoodbeck Dec 9, 2025
f627025
Update sqlglot/typing/snowflake.py
VaggelisD Dec 10, 2025
56cec26
Update sqlglot/typing/snowflake.py
VaggelisD Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sqlglot/dialects/duckdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,6 +967,7 @@ class Generator(generator.Generator):
),
exp.UnixToTime: _unix_to_time_sql,
exp.UnixToTimeStr: lambda self, e: f"CAST(TO_TIMESTAMP({self.sql(e, 'this')}) AS TEXT)",
exp.Variance: rename_func("VAR_SAMP"),
exp.VariancePop: rename_func("VAR_POP"),
exp.WeekOfYear: rename_func("WEEKOFYEAR"),
exp.Xor: bool_xor_sql,
Expand Down
3 changes: 2 additions & 1 deletion tests/dialects/test_duckdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,7 @@ def test_duckdb(self):
},
write={
"": "VARIANCE_POP(x)",
"duckdb": "VAR_POP(x)",
},
)
self.validate_all(
Expand Down Expand Up @@ -1013,7 +1014,7 @@ def test_duckdb(self):
self.validate_all(
"VARIANCE(a)",
write={
"duckdb": "VARIANCE(a)",
"duckdb": "VAR_SAMP(a)",
"clickhouse": "varSamp(a)",
},
)
Expand Down
16 changes: 16 additions & 0 deletions tests/dialects/test_snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,22 @@ def test_snowflake(self):
self.validate_identity("SELECT REGR_SXY(y, x)")
self.validate_identity("SELECT REGR_SYY(y, x)")
self.validate_identity("SELECT REGR_SLOPE(y, x)")
self.validate_all(
"SELECT VAR_SAMP(x)",
write={
"snowflake": "SELECT VARIANCE(x)",
"duckdb": "SELECT VAR_SAMP(x)",
"postgres": "SELECT VAR_SAMP(x)",
},
)
self.validate_all(
"SELECT VAR_POP(x)",
write={
"snowflake": "SELECT VARIANCE_POP(x)",
"duckdb": "SELECT VAR_POP(x)",
"postgres": "SELECT VAR_POP(x)",
},
)
self.validate_all(
"SELECT SKEW(a)",
write={
Expand Down
20 changes: 20 additions & 0 deletions tests/fixtures/optimizer/annotate_functions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4252,6 +4252,26 @@ INT;
MODE(tbl.str_col) OVER (PARTITION BY tbl.int_col);
VARCHAR;

# dialect: snowflake
VAR_SAMP(tbl.double_col);
DOUBLE;

# dialect: snowflake
VARIANCE_SAMP(tbl.double_col);
DOUBLE;

# dialect: snowflake
VARIANCE(tbl.double_col);
DOUBLE;

# dialect: snowflake
VAR_POP(tbl.double_col);
DOUBLE;

# dialect: snowflake
VARIANCE_POP(tbl.double_col);
DOUBLE;

--------------------------------------
-- T-SQL
--------------------------------------
Expand Down