feat(snowflake)!: Annotate type for VAR_POP, VAR_SAMP, DuckDB consistency fix for VAR_SAMP #6488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaggelisD
reviewed
Dec 5, 2025
georgesittas
approved these changes
Dec 8, 2025
VaggelisD
reviewed
Dec 9, 2025
VaggelisD
approved these changes
Dec 10, 2025
Collaborator
There was a problem hiding this comment.
Thank you for the iterations @fivetran-kwoodbeck, this was tricky once again! One final comment to consider, will go ahead and amend it:
sqlglot/typing/snowflake.py
Outdated
|
|
||
| MAX_PRECISION = 38 | ||
|
|
||
| MIN_SCALE = 12 |
Collaborator
There was a problem hiding this comment.
I'd advise against making this a global for now, technically the minimum scale is 0 and we haven't observed anything similar besides VARIANCE iirc.
We can inline this back into the if scale branch and also document that this was found by reverse-engineering Snowflake
Suggested change
| MIN_SCALE = 12 |
VaggelisD
reviewed
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly just tests for Snowflake, but in testing I noticed an inconsistency in naming on duckdb. It uses the alias of VAR_SAMP called VARIANCE. I made it consistent so it's VAR_SAMP and VAR_POP, instead of VARIANCE and VAR_POP. sqlglot/dialects/duckdb.py references a VARIANCE_POP which does not seem to exist.