Skip to content

Conversation

bwitt
Copy link
Contributor

@bwitt bwitt commented Sep 10, 2025

Only set the agent environment if agent_manage_environment is true

Fixes #593

@bwitt
Copy link
Contributor Author

bwitt commented Sep 10, 2025

those failures do not seem related?

@shaun-rutherford
Copy link

Pinging that having this code merged is something we need as well, was going to write it myself when I stumbled on this PR.

@shaun-rutherford
Copy link

Can we get eyes on this please? I really don't want to have to fork this project internally but we need this fixed as it's causing a bit of chaos in our environment.
The failing bits seem to be completely unrelated to this PR.
The failing tests come from:
spec/classes/puppet_server_spec.rb

of which no code changes to that test suit are made in this PR?

@bwitt
Copy link
Contributor Author

bwitt commented Sep 23, 2025

The CI failures are due to inifile breaking support for puppet 7; sounds like we may be moving forward with dropping puppet 7 support

@bwitt
Copy link
Contributor Author

bwitt commented Sep 23, 2025

@shaun-rutherford btw some discussion is happening on the voxpupuli slack if you'd like to join the fun

@bwitt bwitt force-pushed the bwitt/agent-environment-optional branch from 3166cf2 to b86343a Compare October 8, 2025 21:00
@bwitt
Copy link
Contributor Author

bwitt commented Oct 8, 2025

#966 got merged so now all tests should pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make agent 'environment' optional
2 participants