Skip to content

Fixes #38813 - Remove SCA-irrelevant event handling from broker filter#273

Merged
ehelms merged 1 commit intotheforeman:masterfrom
jeremylenz:remove-sca-irrelevant-events
Oct 10, 2025
Merged

Fixes #38813 - Remove SCA-irrelevant event handling from broker filter#273
ehelms merged 1 commit intotheforeman:masterfrom
jeremylenz:remove-sca-irrelevant-events

Conversation

@jeremylenz
Copy link
Contributor

@jeremylenz jeremylenz commented Oct 8, 2025

Katello PR: Katello/katello#11523

Summary

Remove handling of the following Candlepin events from the broker filter as they are irrelevant in SCA-only mode:

  • entitlement.created and entitlement.deleted - related to attaching subscriptions to hosts
  • compliance.created - used to update host subscription status based on subscription attachments
  • system_purpose_compliance.created - used to update host system purpose status based on attached subscriptions

The owner_content_access_mode.modified event is retained as a guard against users attempting to circumvent SCA-only mode.

Related Issues

🤖 Generated with Claude Code

Remove handling of entitlement.created, entitlement.deleted,
compliance.created, and system_purpose_compliance.created events
as they are irrelevant in SCA-only mode. These events relate to
subscription attachments which don't apply in SCA mode.

The owner_content_access_mode.modified event is retained.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked all over the code and this seems to be the only reference of it, ACK. @ehelms can this get a review?

@ehelms
Copy link
Member

ehelms commented Oct 9, 2025

Can you open a PR to also remove them in foremanctl? https://github.com/theforeman/foremanctl/blob/master/src/roles/candlepin/templates/broker.xml.j2#L130

@jeremylenz
Copy link
Contributor Author

Opened theforeman/foremanctl#247

@ehelms ehelms merged commit d719d43 into theforeman:master Oct 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants