Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-intersection-observer/src/InView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ export class InView extends React.Component<
prevProps.triggerOnce !== this.props.triggerOnce ||
prevProps.skip !== this.props.skip ||
prevProps.trackVisibility !== this.props.trackVisibility ||
prevProps.delay !== this.props.delay
prevProps.delay !== this.props.delay ||
prevProps.fallbackInView !== this.props.fallbackInView
) {
this.unobserve();
this.observeNode();
Expand Down
24 changes: 24 additions & 0 deletions packages/react-intersection-observer/src/__tests__/InView.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,30 @@ test("should render with fallback", () => {
}).toThrow();
});

test("should update fallbackInView when the observer is unsupported", () => {
// @ts-expect-error Simulate a browser without IntersectionObserver.
window.IntersectionObserver = undefined;
const callback = vi.fn();
const { rerender } = render(
<InView fallbackInView={true} onChange={callback}>
{({ inView, ref }) => <div ref={ref}>{inView.toString()}</div>}
</InView>,
);
screen.getByText("true");

rerender(
<InView fallbackInView={false} onChange={callback}>
{({ inView, ref }) => <div ref={ref}>{inView.toString()}</div>}
</InView>,
);

screen.getByText("false");
expect(callback).toHaveBeenLastCalledWith(
false,
expect.objectContaining({ isIntersecting: false }),
);
});

test("should render with global fallback", () => {
const cb = vi.fn();
// @ts-expect-error
Expand Down