Repository navigation
fix: observe fallbackInView option updates in InView - #788
Open
feritcemkahraman wants to merge 1 commit into
Open
feritcemkahraman wants to merge 1 commit into
feritcemkahraman wants to merge 1 commit into
Conversation
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@feritcemkahraman is attempting to deploy a commit to the Daniel Schmidt's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When IntersectionObserver is unavailable, changing
<InView fallbackInView>from true to false leaves the rendered visibility and callback at the old value. The class component's observer-option comparison does not include this prop.Include fallbackInView alongside the other observer options. The browser regression rerenders the same component and verifies both rendered state and onChange. It fails before the fix.
Validation:
The Storybook/docs app builds and packed compatibility matrix were not run for this class-component option fix.
Additional validation completed after opening: publint reports no errors (only an engines.node suggestion), and the packed
@arethetypeswrong/cli --packcheck reports no problems for both exports across node10, node16 CJS/ESM, and bundler modes.