Skip to content

fix(theme): match Herdr default palette - #9

Closed
RaviTharuma wants to merge 1 commit into
thanhdat77:mainfrom
RaviTharuma:fix/inherit-herdr-theme
Closed

fix(theme): match Herdr default palette#9
RaviTharuma wants to merge 1 commit into
thanhdat77:mainfrom
RaviTharuma:fix/inherit-herdr-theme

Conversation

@RaviTharuma

Copy link
Copy Markdown
Contributor

Summary

  • use Catppuccin as the inherited fallback when Herdr has no explicit [theme].name
  • keep One Light as Navigator's standalone palette when inherit_herdr = false
  • cover missing and unknown theme names with regression tests

Fixes #5.

Checks

  • cargo fmt --check — unavailable locally because the stable toolchain does not include rustfmt
  • cargo clippy -- -D warnings — blocked by pre-existing clippy::items_after_test_module in src/main.rs
  • cargo test — 67 passed, 2 pre-existing app tests failed (close_target_matches_entry_kind, source_specific_reuse_distinguishes_same_path_workspaces)
  • cargo test theme::tests:: — 5 passed
  • git diff --check

🤖 Generated with Claude Code

Use Catppuccin when inherited theme settings are absent, unreadable,
invalid, or unknown, matching Herdr's own runtime fallback. Keep One
Light as Navigator's standalone palette when inheritance is disabled.

Co-Authored-By: Claude <noreply@anthropic.com>
@RaviTharuma

Copy link
Copy Markdown
Contributor Author

This is the preferred theme-fallback PR for #5. #10 was closed as a duplicate of this one.

@thanhdat77

Copy link
Copy Markdown
Owner

Thanks for identifying the Herdr fallback mismatch and providing the regression coverage. The equivalent fix has since landed on main in 2c83c80: inherited themes now fall back to Catppuccin for missing, unreadable, invalid, or unknown configuration, while inherit_herdr = false keeps One Light. Issue #5 is closed and the current suite passes.

Closing this PR as superseded to avoid merging duplicate changes. Thank you for the contribution.

@thanhdat77 thanhdat77 closed this Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inherited theme does not visually match Herdr

2 participants