fix(theme): match Herdr default palette - #9
Closed
RaviTharuma wants to merge 1 commit into
Closed
Conversation
Use Catppuccin when inherited theme settings are absent, unreadable, invalid, or unknown, matching Herdr's own runtime fallback. Keep One Light as Navigator's standalone palette when inheritance is disabled. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
Owner
|
Thanks for identifying the Herdr fallback mismatch and providing the regression coverage. The equivalent fix has since landed on Closing this PR as superseded to avoid merging duplicate changes. Thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[theme].nameinherit_herdr = falseFixes #5.
Checks
cargo fmt --check— unavailable locally because the stable toolchain does not includerustfmtcargo clippy -- -D warnings— blocked by pre-existingclippy::items_after_test_moduleinsrc/main.rscargo test— 67 passed, 2 pre-existing app tests failed (close_target_matches_entry_kind,source_specific_reuse_distinguishes_same_path_workspaces)cargo test theme::tests::— 5 passedgit diff --check🤖 Generated with Claude Code