Skip to content

fix(theme): match Herdr default palette - #10

Closed
RaviTharuma wants to merge 1 commit into
thanhdat77:mainfrom
RaviTharuma:fix/inherit-herdr-default-theme
Closed

fix(theme): match Herdr default palette#10
RaviTharuma wants to merge 1 commit into
thanhdat77:mainfrom
RaviTharuma:fix/inherit-herdr-default-theme

Conversation

@RaviTharuma

Copy link
Copy Markdown
Contributor

Summary

  • use Catppuccin when Herdr theme inheritance is enabled and no theme name is configured
  • keep One Light as the explicit opt-out palette when inheritance is disabled
  • cover the unset-name behavior with a regression test

Fixes #5

Verification

  • cargo test theme::tests (4 passed)
  • cargo check
  • full cargo test (66 passed; 2 pre-existing app tests fail because they invoke the unavailable herdr executable)
  • formatting check unavailable because the active Rust toolchain does not have rustfmt installed

🤖 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
@RaviTharuma

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of #9, which has the same fix with broader regression coverage for missing/unknown theme names. Please review #9 instead: #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inherited theme does not visually match Herdr

1 participant