Change Required props as optional #788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
January 12, 2022 13:28
christopherGdynia
force-pushed
the
props-as-optional
branch
from
da47ce6 to
1ab00fd
Compare
|
Closing for now, but created a branch without conflicts here https://github.com/telekom/scale/tree/christopherGdynia-props-as-optional We can re-open after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
after trying out how to use the ScaleWebcomponents in JSX (SolidJs, soon also in ReactJS) as described in #615
I have regocnized that there are some props which shouldn't be required as mentioned here #786
This PR will give you an overview about what I have changed with #786
In my mind, the pr should stay opened as long as #786 is open.