Scale Component Properties optional flag

[christopherGdynia]

Hello there,

In #615 I used the ScaleComponents as Webcomponent in Typescript and there are many properties which aren't optional,
because of that, the typescript compiler told me to set these properties

I will make a PR for these, but that are so many, that's why I opened this Issue to take a look at them and discuss which are props are necessarry.

Props that should be requiered:

• label

Props with default values shouldn't be requiered

I will include these that don't match the last two statements.

//chart-stack-card
  @Prop() data: string | Array<Record<'type' | 'value' | 'percentage', string>>;
  @Prop() heading: string;

//data-grid
  @Prop() fields: any;
  @Prop() rows: any;
  @Prop() styles: any;

//date-picker
@Prop() role: string;

//link
  @Prop() href: string; 

//loading-spinner
 @Prop() text: string;

//menu-flyout-list
  @Prop() trigger: () => HTMLElement;

//modal
  @Prop() heading: string;

//notification-badge
  @Prop() clickHandler: any;

//side-bar-nav-item
  @Prop() nestingLevel: number;

//tab-header
  @Prop() selected: boolean;

//app-footer
  @Prop() claimLang: string;

//app-header
 @Prop() claimLang: string;
 @Prop() activeRouteId: string;

// app-logo
  @Prop() claimLang: string;

// app-mega-menu
  @Prop() hide: () => void;
  @Prop() activeRouteId: string;
  @Prop() isActive: boolean;
  @Prop() active: boolean;

// app-navigation-main-mobile
  @Prop() hide: () => void;
  @Prop() navigation: MenuItem[];
  @Prop() activeRouteId: string;

//app-navigation-sector-mobile
  @Prop() hide: () => void;
  @Prop() navigation: MenuItem[];

//app-navation-user-menu
  @Prop() hide: () => void;
  @Prop() navigation: any;

//logo
  @Prop() clickHandler: any;

//nav-icon
  @Prop() isActive: boolean;
  @Prop() active: boolean;
  @Prop() clickLink: any;
  @Prop() icon: string;
  @Prop() badgeLabel: number;

//nav-main
  @Prop() isActive: boolean;
  @Prop() active: boolean;
  @Prop() popup: boolean;
  @Prop() name: string;
  @Prop() clickLink: any;

//nav-segment
  @Prop() isActive: boolean;
  @Prop() active: boolean;

//toggle-button
  @Prop() hideBorder: false;
  @Prop() ariaLabel: string;

We need to decide which of these should stay required and which are optional :)

[acstll]

Thank you very much again! We're adding this to our backlog.

[acstll]

#788 (comment) 👀

[tshimber]

hi @christopherGdynia ! I guess this issue can be closed as you seem to have been fixed it with PR? I haven't faced the problem lately

FYI @amir-ba

[christopherGdynia]

@tshimber tbh I dont know anymore

If we have some problems we do a local workaround or dont use a scale component for the task