Skip to content

fix(data): add TCGplayer group id for 30th Classic Collection - #2445

Merged
FalconChipp merged 1 commit into
tcgdex:masterfrom
cativo23:fix/30th-classic-tcgplayer-group
Oct 6, 2026
Merged

FalconChipp merged 1 commit into
tcgdex:masterfrom
cativo23:fix/30th-classic-tcgplayer-group

Conversation

@cativo23

@cativo23 cativo23 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Changes

  • data/Mega Evolution/30th Classic Collection.ts: add thirdParty.tcgplayer: 24837 (and cardmarket: 6601, matching sibling sets).

Details

Every 30th Classic Collection card returns pricing.tcgplayer: null, although the cards already carry TCGplayer product ids (for example 019 Darkrai & Cresselia LEGEND → 716199). updateTCGPlayerDatas() only fetches prices for sets that have a set-level TCGplayer group id, and this set had none.

  • TCGplayer lists the Classic Collection as its own group: 24837 on tcgcsv is "ME: 30th Celebration Classic Collection", abbreviation 30C, published 2026-09-16 (supplemental), separate from the main set's 24722.
  • All 30 card-level product ids in the set belong to that group; product 716199 (Darkrai & Cresselia Legend (Top)) has a market price of $22.09 (Holofoil).
  • Cardmarket does not split the two: Classic Collection cards such as 907954 carry idExpansion: 6601, the same expansion as the main 30th Celebration set (see the discussion in fix(data): Fold 30th Classic Collection into set 30C #2401). It is set-level metadata only; Cardmarket prices already resolve by card-level id.

No other behaviour changes: prices are cached by product id, and the set endpoint omits thirdParty. Companion to #2444 (main 30th Celebration set).

@TCGdexBOT

Copy link
Copy Markdown
Member

🃏 0 Cards Changed

No recognized card files were changed in this PR.

@FalconChipp
FalconChipp merged commit 4199850 into tcgdex:master Oct 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants