Repository navigation
fix(data): add TCGplayer group id for 30th Classic Collection - #2445
Merged
FalconChipp merged 1 commit intoOct 6, 2026
Merged
Conversation
Member
🃏 0 Cards ChangedNo recognized card files were changed in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
data/Mega Evolution/30th Classic Collection.ts: addthirdParty.tcgplayer: 24837(andcardmarket: 6601, matching sibling sets).Details
Every 30th Classic Collection card returns
pricing.tcgplayer: null, although the cards already carry TCGplayer product ids (for example019Darkrai & Cresselia LEGEND →716199).updateTCGPlayerDatas()only fetches prices for sets that have a set-level TCGplayer group id, and this set had none.24837on tcgcsv is "ME: 30th Celebration Classic Collection", abbreviation 30C, published 2026-09-16 (supplemental), separate from the main set's24722.716199(Darkrai & Cresselia Legend (Top)) has a market price of $22.09 (Holofoil).907954carryidExpansion: 6601, the same expansion as the main 30th Celebration set (see the discussion in fix(data): Fold 30th Classic Collection into set 30C #2401). It is set-level metadata only; Cardmarket prices already resolve by card-level id.No other behaviour changes: prices are cached by product id, and the set endpoint omits
thirdParty. Companion to #2444 (main 30th Celebration set).