Skip to content

fix(data): add TCGplayer group id for 30th Celebration - #2444

Open
cativo23 wants to merge 1 commit into
tcgdex:masterfrom
cativo23:fix/30th-tcgplayer-group
Open

cativo23 wants to merge 1 commit into
tcgdex:masterfrom
cativo23:fix/30th-tcgplayer-group

Conversation

@cativo23

@cativo23 cativo23 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Changes

  • data/Mega Evolution/30th Celebration.ts: add thirdParty.tcgplayer: 24722 (and cardmarket: 6601, matching sibling sets).

Details

Every 30th Celebration card returns pricing.tcgplayer: null, although the cards already carry TCGplayer product ids (for example 30th-130 Moltres → 716219). updateTCGPlayerDatas() only fetches prices for sets that have a set-level TCGplayer group id, and this set had none, so even after the next release none of its products would be loaded.

  • Group 24722 on tcgcsv is "ME: 30th Celebration", abbreviation 30C, published 2026-09-16, the same release date as the set.
  • All 157 card-level product ids in the set belong to that group; product 716219 (Moltres - 130/128) has a market price of $5.71 (Holofoil).
  • Cardmarket expansion 6601: card-level ids such as 907738 (Moltres) and 907654 (Pikachu) carry idExpansion: 6601 in Cardmarket's product catalog. It is set-level metadata only; Cardmarket prices already resolve by card-level id.
  • Same pattern as the other Mega Evolution sets, e.g. Perfect Order (6443 / 24587).

No other behaviour changes: prices are cached by product id, and the set endpoint omits thirdParty. 30th Classic Collection has the same gap (separate TCGplayer group 24837) and gets its own PR.

@TCGdexBOT

Copy link
Copy Markdown
Member

🃏 0 Cards Changed

No recognized card files were changed in this PR.

@cativo23

cativo23 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

Reopening, this was closed by accident. A PR in my own project mentioned it right after the word "fix", so GitHub closed it when that PR merged.

The diff is unchanged. 30th Celebration still has no set-level TCGplayer group id, so its cards keep returning pricing.tcgplayer: null. #2445 did the same change for 30th Classic Collection and is already merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants