Repository navigation
Conversation
Member
🃏 0 Cards ChangedNo recognized card files were changed in this PR. |
Contributor
Author
|
Reopening, this was closed by accident. A PR in my own project mentioned it right after the word "fix", so GitHub closed it when that PR merged. The diff is unchanged. 30th Celebration still has no set-level TCGplayer group id, so its cards keep returning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
data/Mega Evolution/30th Celebration.ts: addthirdParty.tcgplayer: 24722(andcardmarket: 6601, matching sibling sets).Details
Every 30th Celebration card returns
pricing.tcgplayer: null, although the cards already carry TCGplayer product ids (for example30th-130Moltres →716219).updateTCGPlayerDatas()only fetches prices for sets that have a set-level TCGplayer group id, and this set had none, so even after the next release none of its products would be loaded.24722on tcgcsv is "ME: 30th Celebration", abbreviation 30C, published 2026-09-16, the same release date as the set.716219(Moltres - 130/128) has a market price of $5.71 (Holofoil).6601: card-level ids such as907738(Moltres) and907654(Pikachu) carryidExpansion: 6601in Cardmarket's product catalog. It is set-level metadata only; Cardmarket prices already resolve by card-level id.6443/24587).No other behaviour changes: prices are cached by product id, and the set endpoint omits
thirdParty. 30th Classic Collection has the same gap (separate TCGplayer group24837) and gets its own PR.