Non ISO calendar refactor, part 1 #1983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More robust against overridden built-ins for operations such as arr.includes(foo). See #1911 (this only partially fixes the problem)
If the cache was cloned from another one, then existing entries were counted twice.
The argument types in dateFromFields(), yearMonthFromFields(), and monthDayFromFields() were not accurate.
Codecov Report
@@ Coverage Diff @@
## main #1983 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 19 19
Lines 10962 10962
Branches 1742 1742
=======================================
Hits 10410 10410
Misses 535 535
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
justingrant
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains commits from #1977 which @Ms2ger or I already reviewed. (I can't merge it myself since I opened it, so just needs a rubber-stamp review.)