Skip to content

Commit 750c7cc

Browse files
justingrantptomato
authored andcommitted
Update TypeScript types for Calendar methods
The argument types in dateFromFields(), yearMonthFromFields(), and monthDayFromFields() were not accurate.
1 parent fd673c4 commit 750c7cc

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

polyfill/index.d.ts

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -603,8 +603,9 @@ export namespace Temporal {
603603
readonly [Symbol.toStringTag]: 'Temporal.Instant';
604604
}
605605

606-
type EitherYearOrEraAndEraYear = { era: string; eraYear: number } | { year: number };
607-
type EitherMonthCodeOrMonthAndYear = (EitherYearOrEraAndEraYear & { month: number }) | { monthCode: string };
606+
type YearOrEraAndEraYear = { era: string; eraYear: number } | { year: number };
607+
type MonthCodeOrMonthAndYear = (YearOrEraAndEraYear & { month: number }) | { monthCode: string };
608+
type MonthOrMonthCode = { month: number } | { monthCode: string };
608609

609610
export interface CalendarProtocol {
610611
id?: string;
@@ -648,15 +649,15 @@ export namespace Temporal {
648649
date: Temporal.PlainDate | Temporal.PlainDateTime | Temporal.PlainYearMonth | PlainDateLike | string
649650
): boolean;
650651
dateFromFields(
651-
fields: EitherMonthCodeOrMonthAndYear & { day: number },
652+
fields: YearOrEraAndEraYear & MonthOrMonthCode & { day: number },
652653
options?: AssignmentOptions
653654
): Temporal.PlainDate;
654655
yearMonthFromFields(
655-
fields: EitherYearOrEraAndEraYear & ({ month: number } | { monthCode: string }),
656+
fields: YearOrEraAndEraYear & MonthOrMonthCode,
656657
options?: AssignmentOptions
657658
): Temporal.PlainYearMonth;
658659
monthDayFromFields(
659-
fields: EitherMonthCodeOrMonthAndYear & { day: number },
660+
fields: MonthCodeOrMonthAndYear & { day: number },
660661
options?: AssignmentOptions
661662
): Temporal.PlainMonthDay;
662663
dateAdd(
@@ -726,15 +727,15 @@ export namespace Temporal {
726727
date: Temporal.PlainDate | Temporal.PlainDateTime | Temporal.PlainYearMonth | PlainDateLike | string
727728
): boolean;
728729
dateFromFields(
729-
fields: EitherMonthCodeOrMonthAndYear & { day: number },
730+
fields: YearOrEraAndEraYear & MonthOrMonthCode & { day: number },
730731
options?: AssignmentOptions
731732
): Temporal.PlainDate;
732733
yearMonthFromFields(
733-
fields: EitherYearOrEraAndEraYear & ({ month: number } | { monthCode: string }),
734+
fields: YearOrEraAndEraYear & MonthOrMonthCode,
734735
options?: AssignmentOptions
735736
): Temporal.PlainYearMonth;
736737
monthDayFromFields(
737-
fields: EitherMonthCodeOrMonthAndYear & { day: number },
738+
fields: MonthCodeOrMonthAndYear & { day: number },
738739
options?: AssignmentOptions
739740
): Temporal.PlainMonthDay;
740741
dateAdd(

0 commit comments

Comments
 (0)