Update ExportCommand.py with file name sanitisation#29
Open
gsokoll wants to merge 4 commits intotapnair:masterfrom
Open
Update ExportCommand.py with file name sanitisation#29gsokoll wants to merge 4 commits intotapnair:masterfrom
gsokoll wants to merge 4 commits intotapnair:masterfrom
Conversation
Add "slugify" method to sanitise filenames (removing haracters that aren't alphanumerics, underscores, or hyphens, and strip leading and trailing whitespace, dashes, and underscores).
Update ExportCommand.py
|
Just tried this, and it solved issues I was having with tapnair's original script. However, I had to add: Am I missing something here, or did you forget to import the unicodedata and re libraries? |
Author
|
Sorry, yes I forgot to add those. I originally made changes to the local installation on my PC, and only created the fork and pull request afterwards from memory of what I changed. I will see if I can fix in the pull request. |
|
I would also change so that the folder name is sanitized too. |
|
integrated the closing change and the file name issue here https://github.com/o-gent/Project-Archiver |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "slugify" method to sanitise filenames (removing haracters that aren't alphanumerics, underscores, or hyphens, and strip leading and trailing whitespace, dashes, and underscores).
Addresses issues #19 and #20