tww: Load offsets from custom_symbols.txt file#3
Open
Aelire wants to merge 1 commit intotanjo3:mainfrom
Open
Conversation
This makes it simpler to update the client in lockstep with the randomizer and for development, by copying or symlinking the custom_symbols.txt file Signed-off-by: Erilea <erilea@erilea.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This makes it simpler to update the client in lockstep with the randomizer and for development, by copying or symlinking the custom_symbols.txt file. Since even unrelated changes to the asm setup can cause offsets to change wildly, this should reduce the number of offsets that need copy-pasted on every client change
The
custom_symbols.txtincluded in this PR is fromap_2.5.1I also have a version of this rebased on top of
fix-duplicate-itemsif that's a better target branch but the changes are minimalLet me know if this is interesting and I can rerun some testing to make sure this exact commit works, and/or send directly upstream if that's better
How was this tested?
not yet tested independently on this exact version, but used with other changes to test synced changes between the randomizer and the archipelago client; did 3-4 of the following process:
custom_symbols.txtinto here