chore(sda): retire completed fixed-SHA reconciliation - #352
Conversation
Signed-off-by: Lutar, Stephen P. <stephenlutar2@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa11a88946
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| - .github/scripts/test_sda_reconcile_retired.py | ||
| - .github/workflows/sda-reconcile-retirement.yml | ||
| - .github/workflows/sda-shared-source-reconcile.yml | ||
| - .github/scripts/sda_shared_source_reconcile.py | ||
| - .github/data/sda_shared_source_reconcile.json |
There was a problem hiding this comment.
Run the retirement scan for every executable change
The test scans every Python/YAML/JSON file under .github/workflows and .github/scripts, but this workflow runs only when one of these five fixed paths changes. A PR can therefore restore the historical controller or its forbidden markers under a renamed script/workflow without triggering this job, and .github/workflows/tests.yml does not invoke the new test either. Trigger on the directories being scanned or add this test to the repository-wide Tests workflow so the tombstone actually prevents renamed resurrection.
Useful? React with 👍 / 👎.
Satisfies
Satisfies C-158 and completed report #221. Replaces conflicted PR #348 and stale-base replacement #351 without rewriting either history.
Root cause
The organization health digest still exposes
Reconcile A11oy and Killinchu SDA shared source, a completed one-shot controller bound to historical PR #1028 and fixed branch SHAs. Current evidence already proves both sharedszl_ecosystem_routes.pyfiles resolve to Git blob9564c47daf79c86815b2544ec51b06debc30d354; issue #221 is closed.Keeping the controller executable permits it to target stale branches and reopen a resolved incident.
Permanent retirement
Exact current-base lineage
Commit
fa11a889465e2783b2aac44053b4fc61aeb09503is based directly on protectedmainSHA47607d3149dd54c4e107d7eeb2129ebdff5d2d03, SSH-signed, and DCO-signed-off. Its two added blobs are byte-for-byte identical to the previously verified signed replacement; the same three obsolete paths are deleted. No force push or history rewrite was used.Verification
git diff --checkpassedLabels: PROVED exact signed replacement and retirement tombstone; MEASURED stale completed controller; NOT CLAIMED product-state change beyond removing obsolete mutation authority.
Rollback: Restore only through a protected pull request carrying a new reviewed reconciliation manifest and new immutable targets.
Risk class
Risk B - deletion of a completed source-control mutation one-shot and addition of a read-only tombstone test.
Solo-Operator-Authorization: confirmed
Signed-off-by: Stephen P. Lutar Jr. stephenlutar2@gmail.com