riscv64: improve sbi and ipi code #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on improving RISC-V SBI and IPI handling by updating the supported SBI extensions, enhancing the software interrupt (IPI) handler to process multiple events, and adding a new IPI event for sending software interrupts.
- Introduces a new constant IPI_EVENT_SEND_IPI and its corresponding branch in the event handler.
- Adjusts UART functions to use renamed SBI console I/O functions.
- Updates various RISC-V related modules to use the new riscv_h dependency and improves logging and trap handling.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/event.rs | Added new IPI event definition and branch in check_events. |
| src/device/uart/mod.rs | Re-export updated SBI console I/O functions with new naming. |
| src/device/irqchip/plic/vplic.rs | Updated calls from riscv to riscv_h for interrupt handling. |
| src/device/irqchip/plic/mod.rs | Switched logging from warn to debug/info and updated hvip usage. |
| src/device/irqchip/aia/aplic.rs | Removed unused imports. |
| src/arch/riscv64/trap.rs | Refactored trap vector installation and updated exception handling. |
| src/arch/riscv64/ipi.rs | Added the arch_ipi_handler function to set a software interrupt flag. |
| Cargo.toml | Replaced the old riscv dependency with versioned riscv and riscv_h. |
src/event.rs
Outdated
| } | ||
| #[cfg(target_arch = "riscv64")] | ||
| Some(IPI_EVENT_SEND_IPI) => { | ||
| // This event is different form events above, it is used to inject software interrupt. |
There was a problem hiding this comment.
[nitpick] Typo in the comment on line 148: consider replacing 'form' with 'from'.
Suggested change
| // This event is different form events above, it is used to inject software interrupt. | |
| // This event is different from events above, it is used to inject software interrupt. |
enkerewpo
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request contains content below: