Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPUnit test action #342

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Add PHPUnit test action #342

merged 2 commits into from
Dec 30, 2024

Conversation

tobias-93
Copy link
Member

No description provided.

@tobias-93 tobias-93 force-pushed the add-phpunit-action branch 2 times, most recently from 4d3e532 to 65b4693 Compare December 27, 2024 16:33
@tobias-93 tobias-93 marked this pull request as ready for review December 27, 2024 17:36
@tobias-93 tobias-93 mentioned this pull request Dec 27, 2024
Copy link
Member

@bobvandevijver bobvandevijver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a couple of changes unrelated to the test action addition have been added (changes signatures outside the test directory, doctrine & pagerfanta version bumbs). Those need to be in a separate PR to be able to generate correct release notes.

(we should also update the UPGRADE.MD for those and previous changes).

@tobias-93 tobias-93 force-pushed the add-phpunit-action branch 2 times, most recently from 5f44d8e to 66464e2 Compare December 29, 2024 17:15
@tobias-93
Copy link
Member Author

Depends on #344

@bobvandevijver bobvandevijver merged commit 96a5abc into master Dec 30, 2024
3 checks passed
@bobvandevijver bobvandevijver deleted the add-phpunit-action branch December 30, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants