Skip to content

Commit

Permalink
Update tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@tobias-93
tobias-93 committed Dec 27, 2024
1 parent a8cacd1 commit 65b4693
Show file tree
Hide file tree
Showing 29 changed files with 750 additions and 750 deletions.
26 changes: 0 additions & 26 deletions .travis.yml
View file

This file was deleted.

2 changes: 1 addition & 1 deletion Generator/Column.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class Column

protected string|array $credentials = 'AdmingenAllowed';

protected bool $filtersCredentials = false;
protected bool|string|array $filtersCredentials = false;

protected string $gridClass = '';

Expand Down
40 changes: 20 additions & 20 deletions Tests/Builder/BaseBuilderTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,71 +7,71 @@

class BaseBuilderTest extends TestCase
{
public function testGetSimpleClassName()
public function testGetSimpleClassName(): void
{
$builder = new BaseBuilder();
$this->assertEquals('BaseBuilder', $builder->getSimpleClassName(), 'getSimpleClassName remove the namespaced part of get_class');
$this->assertEquals('Bar', $builder->getSimpleClassName('\\Foo\\Bar'), 'getSimpleClassName remove the namespaced part of get_class');
}

public function testGetDefaultTemplateName()
public function testGetDefaultTemplateName(): void
{
$builder = new BaseBuilder();
$this->assertEquals('BaseBuilder.php.twig', $builder->getDefaultTemplateName(), 'getDefaultTemplateName return the twig file path');
}

public function testSetVariables()
public function testSetVariables(): void
{
$builder = new BaseBuilder();
$builder->setVariables(array('foo' => 'bar'));
$this->assertEquals(array('foo' => 'bar'), $builder->getVariables(), 'setVariables accept an array');
$builder->setVariables(['foo' => 'bar']);
$this->assertEquals(['foo' => 'bar'], $builder->getVariables(), 'setVariables accept an array');
}

public function testGetVariable()
public function testGetVariable(): void
{
$builder = new BaseBuilder();
$builder->setVariables(array('foo' => 'bar'));
$builder->setVariables(['foo' => 'bar']);
$this->assertEquals('bar', $builder->getVariable('foo','default'));
$this->assertEquals('default', $builder->getVariable('nonexistant','default'));

$builder->setVariables(array('foo' => array('bar' =>'bazz')));
$builder->setVariables(['foo' => ['bar' =>'bazz']]);
$foo = $builder->getVariable('foo');
$this->assertEquals('bazz', $foo['bar']);
}

public function testHasVariable()
public function testHasVariable(): void
{
$builder = new BaseBuilder();
$builder->setVariables(array('foo' => 'bar'));
$builder->setVariables(['foo' => 'bar']);
$this->assertTrue($builder->hasVariable('foo'), 'hasVariable return true on a valid key');
$this->assertFalse($builder->hasVariable('var'), 'hasVariable return false on a invalid key');
}

public function testGetCode()
public function testGetCode(): void
{
$builder = $this->initBuilder();

$this->assertEquals('Hello cedric!'."\n", $builder->getCode());

$builder->setVariables(array('name' => 'Tux'));
$builder->setVariables(['name' => 'Tux']);
$this->assertEquals('Hello Tux!'."\n", $builder->getCode(), 'If I change variables code is changed');
}

public function testWriteOnDisk()
public function testWriteOnDisk(): void
{
$builder = $this->initBuilder();

$builder->writeOnDisk(sys_get_temp_dir());
$this->assertTrue(file_exists(sys_get_temp_dir() . '/test.php'));
$this->assertEquals('Hello cedric!'."\n", file_get_contents(sys_get_temp_dir() . '/test.php'));

$builder->setVariables(array('name' => 'Tux'));
$builder->setVariables(['name' => 'Tux']);
$builder->writeOnDisk(sys_get_temp_dir());
$this->assertTrue($builder->mustOverwriteIfExists());
$this->assertTrue(file_exists(sys_get_temp_dir() . '/test.php'));
$this->assertEquals('Hello Tux!'."\n", file_get_contents(sys_get_temp_dir() . '/test.php'), 'If i change variables code is changed');

$builder->setVariables(array('name' => 'cedric'));
$builder->setVariables(['name' => 'cedric']);
$builder->setMustOverwriteIfExists(false);
$builder->writeOnDisk(sys_get_temp_dir());
$this->assertFalse($builder->mustOverwriteIfExists());
Expand All @@ -84,14 +84,14 @@ public function testWriteOnDisk()
$this->assertEquals('Hello cedric!'."\n", file_get_contents(sys_get_temp_dir() . '/test.php'), 'If i change variables on a non existant files code is generated');
}

public function testGetModelClass()
public function testGetModelClass(): void
{
$builder = new BaseBuilder();
$builder->setVariables(array('model' => 'Admingenerator\DemoBundle\Entity\Movie'));
$builder->setVariables(['model' => 'Admingenerator\DemoBundle\Entity\Movie']);
$this->assertEquals('Movie', $builder->getModelClass());
}

protected function initBuilder()
protected function initBuilder(): BaseBuilder
{
$builder = new BaseBuilder();
$generator = $this->getMockBuilder('Admingenerator\GeneratorBundle\Builder\Generator')
Expand All @@ -102,8 +102,8 @@ protected function initBuilder()
$builder->setGenerator($generator);
$builder->setMustOverwriteIfExists(true);
$builder->setOutputName('test.php');
$builder->setTemplateDirs(array(__DIR__.'/Fixtures/'));
$builder->setVariables(array('name' => 'cedric'));
$builder->setTemplateDirs([__DIR__.'/Fixtures/']);
$builder->setVariables(['name' => 'cedric']);
$builder->setTemplateName($builder->getDefaultTemplateName());

return $builder;
Expand Down
14 changes: 7 additions & 7 deletions Tests/ClassLoader/AdmingeneratedClassLoaderTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,22 @@ class AdmingeneratedClassLoaderTest extends TestCase
/**
* @dataProvider getLoadClassTests
*/
public function testLoadClass($className, $testClassName, $message)
public function testLoadClass($className, $testClassName, $message): void
{
$loader = new AdmingeneratedClassLoader();
$loader->setBasePath(realpath(sys_get_temp_dir()));
$loader->register(realpath(sys_get_temp_dir()));
$loader->loadClass($testClassName);
$this->assertTrue(class_exists($className), $message);
}

public function getLoadClassTests()
public function getLoadClassTests(): array
{
return array(
array(
return [
[
'\\Admingenerated\\AdmingeneratorDemoBundle\\BaseController\\ListController',
'Admingenerated\\AdmingeneratorDemoBundle\\BaseController\\ListController',
'->loadClass() loads admingenerated class'
),
);
],
];
}
}
64 changes: 30 additions & 34 deletions Tests/DependencyInjection/ConfigurationTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@
namespace Admingenerator\GeneratorBundle\Tests\DependencyInjection;

use Admingenerator\GeneratorBundle\DependencyInjection\Configuration;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Config\Definition\Processor;

class ConfigurationTest extends \PHPUnit_Framework_TestCase
class ConfigurationTest extends TestCase
{
/**
* Test that default configuration is correctly initialized
*/
public function testDefaultConfig()
public function testDefaultConfig(): void
{
$processor = new Processor();
$config = $processor->processConfiguration(new Configuration('admingen_generator'), array());
Expand All @@ -21,13 +22,10 @@ public function testDefaultConfig()
/**
* Get waiting default values from configuration. If $key is not null
* and is in first level keys, returns value of this specific key only.
*
* @param string $key
* @return mixed
*/
private function getBundleDefaultConfig($key = null)
private function getBundleDefaultConfig(string $key = null): mixed
{
static $defaultConfiguration = array(
static $defaultConfiguration = [
'generate_base_in_project_dir' => false,
'use_doctrine_orm' => false,
'use_doctrine_odm' => false,
Expand All @@ -46,22 +44,22 @@ private function getBundleDefaultConfig($key = null)
'use_doctrine_orm_batch_remove' => false,
'use_doctrine_odm_batch_remove' => false,
'use_propel_batch_remove' => false,
'twig' => array(
'twig' => [
'use_form_resources' => true,
'use_localized_date' => false,
'date_format' => 'Y-m-d',
'datetime_format' => 'Y-m-d H:i:s',
'localized_date_format' => 'medium',
'localized_datetime_format' => 'medium',
'number_format' => array(
'number_format' => [
'decimal' => 0,
'decimal_point' => '.',
'thousand_separator' => ','
)
),
'templates_dirs' => array(),
'form_types' => array(
'doctrine_orm' => array(
]
],
'templates_dirs' => [],
'form_types' => [
'doctrine_orm' => [
'datetime' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
'vardatetime' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
'datetimetz' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
Expand All @@ -78,8 +76,8 @@ private function getBundleDefaultConfig($key = null)
'collection' => 'Symfony\Component\Form\Extension\Core\Type\CollectionType',
'array' => 'Symfony\Component\Form\Extension\Core\Type\CollectionType',
'boolean' => 'Symfony\Component\Form\Extension\Core\Type\CheckboxType',
),
'doctrine_odm' => array(
],
'doctrine_odm' => [
'datetime' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
'timestamp' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
'vardatetime' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
Expand All @@ -101,8 +99,8 @@ private function getBundleDefaultConfig($key = null)
'collection' => 'Symfony\Component\Form\Extension\Core\Type\CollectionType',
'hash' => 'Symfony\Component\Form\Extension\Core\Type\CollectionType',
'boolean' => 'Symfony\Component\Form\Extension\Core\Type\CheckboxType',
),
'propel' => array(
],
'propel' => [
'TIMESTAMP' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
'BU_TIMESTAMP' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
'DATE' => 'Symfony\Component\Form\Extension\Core\Type\DateType',
Expand All @@ -129,10 +127,10 @@ private function getBundleDefaultConfig($key = null)
'ENUM' => 'Symfony\Component\Form\Extension\Core\Type\ChoiceType',
'BOOLEAN' => 'Symfony\Component\Form\Extension\Core\Type\CheckboxType',
'BOOLEAN_EMU' => 'Symfony\Component\Form\Extension\Core\Type\CheckboxType',
),
),
'filter_types' => array(
'doctrine_orm' => array(
],
],
'filter_types' => [
'doctrine_orm' => [
'datetime' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
'vardatetime' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
'datetimetz' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
Expand All @@ -149,8 +147,8 @@ private function getBundleDefaultConfig($key = null)
'collection' => 'Symfony\Component\Form\Extension\Core\Type\CollectionType',
'array' => 'Symfony\Component\Form\Extension\Core\Type\TextType',
'boolean' => 'Symfony\Component\Form\Extension\Core\Type\ChoiceType',
),
'doctrine_odm' => array(
],
'doctrine_odm' => [
'datetime' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
'timestamp' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
'vardatetime' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
Expand All @@ -172,8 +170,8 @@ private function getBundleDefaultConfig($key = null)
'collection' => 'Symfony\Component\Form\Extension\Core\Type\CollectionType',
'hash' => 'Symfony\Component\Form\Extension\Core\Type\TextType',
'boolean' => 'Symfony\Component\Form\Extension\Core\Type\ChoiceType',
),
'propel' => array(
],
'propel' => [
'TIMESTAMP' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
'BU_TIMESTAMP' => 'Symfony\Component\Form\Extension\Core\Type\DateTimeType',
'DATE' => 'Symfony\Component\Form\Extension\Core\Type\DateType',
Expand All @@ -200,16 +198,14 @@ private function getBundleDefaultConfig($key = null)
'ENUM' => 'Symfony\Component\Form\Extension\Core\Type\TextType',
'BOOLEAN' => 'Symfony\Component\Form\Extension\Core\Type\ChoiceType',
'BOOLEAN_EMU' => 'Symfony\Component\Form\Extension\Core\Type\ChoiceType',
),
),
'stylesheets' => array(),
'javascripts' => array(),
],
],
'stylesheets' => [],
'javascripts' => [],
'default_action_after_save' => 'edit',
'throw_exceptions' => false,
'use_doctrine_orm_batch_remove' => false,
'use_doctrine_odm_batch_remove' => false,
'use_propel_batch_remove' => false,
);
'generate_base_in_project_dir_directory' => 'admin',
];

if (!is_null($key) && array_key_exists($key, $defaultConfiguration)) {
return $defaultConfiguration[$key];
Expand Down
19 changes: 8 additions & 11 deletions Tests/Filesystem/RelativePathComputerTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,32 +2,29 @@
namespace Admingenerator\GeneratorBundle\Tests\Filesystem;

use Admingenerator\GeneratorBundle\Filesystem\RelativePathComputer;
use LogicException;
use PHPUnit\Framework\TestCase;

/**
* Class RelativePathComputerTest
* @package Admingenerator\GeneratorBundle\Tests\Filesystem
* @author Stéphane Escandell
*/
class RelativePathComputerTest extends \PHPUnit_Framework_TestCase
class RelativePathComputerTest extends TestCase
{
public function testComputingToParent()
public function testComputingToParent(): void
{
$referencePath = __FILE__;

$computer = new RelativePathComputer($referencePath);
$this->assertEquals(str_repeat('..' . DIRECTORY_SEPARATOR, 1), $computer->computeToParent(dirname($referencePath)));
$this->assertEquals(str_repeat('..' . DIRECTORY_SEPARATOR, 3), $computer->computeToParent(dirname(dirname(dirname($referencePath)))));
$this->assertEquals(str_repeat('..' . DIRECTORY_SEPARATOR, 3), $computer->computeToParent(dirname($referencePath, 3)));

$referencePath = dirname($referencePath);
$computer = new RelativePathComputer($referencePath);
$this->assertEquals(str_repeat('..' . DIRECTORY_SEPARATOR, 1), $computer->computeToParent(dirname($referencePath)));
$this->assertEquals(str_repeat('..' . DIRECTORY_SEPARATOR, 3), $computer->computeToParent(dirname(dirname(dirname($referencePath)))));
$this->assertEquals(str_repeat('..' . DIRECTORY_SEPARATOR, 3), $computer->computeToParent(dirname($referencePath, 3)));
}

public function testExceptionThrowIfNotParent()
public function testExceptionThrowIfNotParent(): void
{
$computer = new RelativePathComputer(__FILE__);
$this->setExpectedException('\LogicException');
$this->expectException(LogicException::class);

$computer->computeToParent(dirname(__FILE__) . DIRECTORY_SEPARATOR . 'Fake');
}
Expand Down
Loading

0 comments on commit 65b4693

Please sign in to comment.