fix(http): make timeout errors easier to understand#3214
Open
SaurabhCodesAI wants to merge 1 commit intosuperplanehq:mainfrom
Open
fix(http): make timeout errors easier to understand#3214SaurabhCodesAI wants to merge 1 commit intosuperplanehq:mainfrom
SaurabhCodesAI wants to merge 1 commit intosuperplanehq:mainfrom
Conversation
When an HTTP request times out, the error shown to the user is the raw Go error 'context deadline exceeded', which is not helpful. This change catches the deadline exceeded error and returns a human-readable message like 'request timed out after 10s' instead. Fixes superplanehq#3198 Signed-off-by: saurabh <saurabhpareek228@gmail.com>
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 12. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timeout errors currently show the raw Go error context deadline exceeded. This change returns a clear message like request timed out after 10s instead.
Fixes #3198