Skip to content

fix: read HTTP response body before context cancellation #3146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clarabennettdev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: read HTTP response body before context cancellation #3146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pkg/components/http/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,18 @@ func (e *HTTP) executeRequest(httpCtx core.HTTPContext, spec Spec, timeout time.
return nil, err
}

// Read the entire response body before returning, because the deferred
// cancel() will cancel the request context and abort any in-flight reads.
// We replace resp.Body with the buffered content so callers (processResponse)
// can read it without hitting "context canceled" errors.
// See: https://github.com/superplanehq/superplane/issues/3141
bodyBytes, err := io.ReadAll(resp.Body)
resp.Body.Close()
if err != nil {
return nil, fmt.Errorf("failed to read response body: %w", err)
}
resp.Body = io.NopCloser(bytes.NewReader(bodyBytes))

return resp, nil
}

Expand Down