fix: read HTTP response body before context cancellation#3146
Open
clarabennettdev wants to merge 1 commit intosuperplanehq:mainfrom
Open
fix: read HTTP response body before context cancellation#3146clarabennettdev wants to merge 1 commit intosuperplanehq:mainfrom
clarabennettdev wants to merge 1 commit intosuperplanehq:mainfrom
Conversation
Fixes superplanehq#3141 In executeRequest, the request context is canceled via defer cancel() when the function returns. However, the response body is read later in processResponse, which causes 'context canceled' errors for large or slow responses. The fix reads the entire response body before executeRequest returns (while the context is still active) and replaces resp.Body with a buffered reader so processResponse can consume it normally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3141
Problem
The HTTP component fails with
failed to read response body: context canceledeven when the server returns status 200. This happens becauseexecuteRequestcreates a context withdefer cancel(), which cancels the context when the function returns — beforeprocessResponsecan read the response body.Fix
Read the entire response body within
executeRequest(while the context is still active) and replaceresp.Bodywith a bufferedio.NopCloser(bytes.NewReader(...)). This wayprocessResponsecan consume the body normally without context cancellation issues.Minimal, targeted fix — no signature or control flow changes.