Skip to content

docs(ptouch): korrigiere Tape-Klassen-Namen (Audit #67) #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
strausmann merged 1 commit into from
Jun 14, 2026
Merged

docs(ptouch): korrigiere Tape-Klassen-Namen (Audit #67) #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/docs/ptouch-integration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Version: `ptouch>=1.1.0` (pinned in pyproject.toml).
- `ptouch.ConnectionNetwork(host: str, port: int = 9100, timeout: float = 5.0)`
- `ptouch.PTP750W(connection, use_compression=None, high_resolution=None)` (subclass of `LabelPrinter`)
- `ptouch.Label(image: PIL.Image.Image, tape: type[Tape] | Tape)`
- Tape classes: `ptouch.LaminatedTape4mm` ... `ptouch.LaminatedTape24mm` (size suffix matches `tape_mm`).
- Tape classes: `ptouch.Tape3_5mm`, `ptouch.Tape6mm`, `ptouch.Tape9mm`, `ptouch.Tape12mm`, `ptouch.Tape18mm`, `ptouch.Tape24mm`, `ptouch.Tape36mm` (size suffix matches `tape_mm`; 3.5mm is the actual narrow tape — `ptouch.Tape4mm` does not exist). `LaminatedTape*mm` variants exist parallel; we use the plain `Tape*mm` form which is the laminated default for PT-series.

@gemini-code-assist gemini-code-assist Bot Jun 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Der Hinweis (size suffix matches tape_mm; ...) ist für Tape3_5mm leicht irreführend. Im Code (ptouch_backend.py und pt.py) wird für dieses Band tape_mm = 4 verwendet (da es kein Tape4mm gibt). Daher stimmt das Suffix 3_5mm hier nicht mit dem numerischen Wert 4 von tape_mm überein. Es wäre verständlicher, diese Ausnahme explizit zu erwähnen.

Suggested change
- Tape classes: `ptouch.Tape3_5mm`, `ptouch.Tape6mm`, `ptouch.Tape9mm`, `ptouch.Tape12mm`, `ptouch.Tape18mm`, `ptouch.Tape24mm`, `ptouch.Tape36mm` (size suffix matches `tape_mm`; 3.5mm is the actual narrow tape — `ptouch.Tape4mm` does not exist). `LaminatedTape*mm` variants exist parallel; we use the plain `Tape*mm` form which is the laminated default for PT-series.
- Tape classes: ptouch.Tape3_5mm, ptouch.Tape6mm, ptouch.Tape9mm, ptouch.Tape12mm, ptouch.Tape18mm, ptouch.Tape24mm, ptouch.Tape36mm (size suffix matches tape_mm except for 3.5mm which maps to tape_mm=4 — ptouch.Tape4mm does not exist). LaminatedTape*mm variants exist parallel; we use the plain Tape*mm form which is the laminated default for PT-series.

- Print method: `LabelPrinter.print(label, margin_mm=None, high_resolution=None, feed=True, auto_cut=None, half_cut=None)`

## ptouch exception hierarchy (caught by PTouchBackend and rewrapped)
Expand Down
Loading