docs(ptouch): korrigiere Tape-Klassen-Namen (Audit #67)#118
Conversation
…(Audit #67) Die Doku sagte: ptouch.LaminatedTape4mm ... ptouch.LaminatedTape24mm Tatsächlich verwendet ptouch_backend.py: ptouch.Tape3_5mm, Tape6mm, Tape9mm, Tape12mm, Tape18mm, Tape24mm, Tape36mm Doppelter Doc-Fehler: 1. Klassennamen: code nutzt `Tape*mm`, nicht `LaminatedTape*mm` (beide existieren, aber Code+Tests nutzen die unlaminated-prefix-freie Variante — das ist die laminated-Default für PT-Series). 2. Schmalste Tape ist 3.5mm, nicht 4mm — `ptouch.Tape4mm` existiert nicht im upstream-Modul. Code-Verifikation: $ python -c "import ptouch; print([n for n in dir(ptouch) if 'ape' in n])" ['LaminatedTape', 'LaminatedTape12mm', 'LaminatedTape18mm', ... 'Tape', 'Tape12mm', 'Tape18mm', 'Tape24mm', 'Tape36mm', 'Tape3_5mm', 'Tape6mm', 'Tape9mm', ...] Refs #67 Audit-Punkt: "PR #59 — ptouch-integration.md:10 Doc says LaminatedTape*mm, Code uses Tape*mm" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! Diese Pull Request korrigiert Ungenauigkeiten in der Dokumentation zur Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ptouch-integration.md documentation to list the correct ptouch.Tape*mm classes instead of the older LaminatedTape*mm variants. The review feedback points out that stating the size suffix matches tape_mm is misleading for Tape3_5mm (which maps to tape_mm = 4 in the codebase) and suggests a clearer phrasing to prevent confusion.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| - `ptouch.PTP750W(connection, use_compression=None, high_resolution=None)` (subclass of `LabelPrinter`) | ||
| - `ptouch.Label(image: PIL.Image.Image, tape: type[Tape] | Tape)` | ||
| - Tape classes: `ptouch.LaminatedTape4mm` ... `ptouch.LaminatedTape24mm` (size suffix matches `tape_mm`). | ||
| - Tape classes: `ptouch.Tape3_5mm`, `ptouch.Tape6mm`, `ptouch.Tape9mm`, `ptouch.Tape12mm`, `ptouch.Tape18mm`, `ptouch.Tape24mm`, `ptouch.Tape36mm` (size suffix matches `tape_mm`; 3.5mm is the actual narrow tape — `ptouch.Tape4mm` does not exist). `LaminatedTape*mm` variants exist parallel; we use the plain `Tape*mm` form which is the laminated default for PT-series. |
There was a problem hiding this comment.
Der Hinweis (size suffix matches tape_mm; ...) ist für Tape3_5mm leicht irreführend. Im Code (ptouch_backend.py und pt.py) wird für dieses Band tape_mm = 4 verwendet (da es kein Tape4mm gibt). Daher stimmt das Suffix 3_5mm hier nicht mit dem numerischen Wert 4 von tape_mm überein. Es wäre verständlicher, diese Ausnahme explizit zu erwähnen.
| - Tape classes: `ptouch.Tape3_5mm`, `ptouch.Tape6mm`, `ptouch.Tape9mm`, `ptouch.Tape12mm`, `ptouch.Tape18mm`, `ptouch.Tape24mm`, `ptouch.Tape36mm` (size suffix matches `tape_mm`; 3.5mm is the actual narrow tape — `ptouch.Tape4mm` does not exist). `LaminatedTape*mm` variants exist parallel; we use the plain `Tape*mm` form which is the laminated default for PT-series. | |
| - Tape classes: ptouch.Tape3_5mm, ptouch.Tape6mm, ptouch.Tape9mm, ptouch.Tape12mm, ptouch.Tape18mm, ptouch.Tape24mm, ptouch.Tape36mm (size suffix matches tape_mm except for 3.5mm which maps to tape_mm=4 — ptouch.Tape4mm does not exist). LaminatedTape*mm variants exist parallel; we use the plain Tape*mm form which is the laminated default for PT-series. |
## <small>0.10.2 (2026-06-15)</small> * refactor(main): _resolve_model_id_from_config nimmt PrinterYAMLConfig statt Any (#67) (#123) ([2ff51d2](2ff51d2)), closes [#67](#67) [#123](#123) [#67](#67) [#59](#59) [#67](#67) [#59](#59) * refactor(snipeit): typisiere response payload als TypedDict statt dict[str, Any] (#67) (#122) ([e88601b](e88601b)), closes [#67](#67) [#122](#122) [#67](#67) [#67](#67) [#51](#51) * perf(lifespan): plugin-discovery in Thread auslagern (Audit #67) (#121) ([48215b4](48215b4)), closes [#67](#67) [#121](#121) [#67](#67) [#59](#59) * fix(config): stricter validation for log_level + webhook_api_key (#46) (#116) ([6b8ac30](6b8ac30)), closes [#46](#46) [#116](#116) [#46](#46) [#46](#46) [#46](#46) [#46](#46) [#116](#116) * fix(print): copies-replication erzeugt UNIQUE job_ids (Round 2 #hangar-109) (#120) ([bd781ae](bd781ae)), closes [#hangar-109](https://github.com/strausmann/label-printer-hub/issues/hangar-109) [#120](#120) [#115](#115) * fix(print): PrintOptions.copies replicates images for hardware print (#hangar-109) (#115) ([d27bbcc](d27bbcc)), closes [#hangar-109](https://github.com/strausmann/label-printer-hub/issues/hangar-109) [#115](#115) [strausmann/hangar#109](https://github.com/strausmann/hangar/issues/109) * docs(metrics): präzisiere sse_events_published_total Beschreibung (Audit #67) (#119) ([ab8c4c4](ab8c4c4)), closes [#67](#67) [#119](#119) [#67](#67) [#67](#67) [#65](#65) * docs(ptouch): korrigiere Tape-Klassen-Namen in ptouch-integration.md (Audit #67) (#118) ([0faab99](0faab99)), closes [#67](#67) [#118](#118) [#67](#67) [#59](#59) * chore(readme): codecov badge ohne embedded Token (Audit #67) (#117) ([4bb5423](4bb5423)), closes [#67](#67) [#117](#117) [#67](#67) [#59](#59) [skip ci]
Summary
Doku-Fix in
backend/docs/ptouch-integration.md:ptouch.Tape*mm(verifiziert inprinter_backends/ptouch_backend.py), nichtLaminatedTape*mmTape3_5mm, nichtTape4mm(existiert nicht im upstream)Beide Klassen existieren im ptouch-Modul parallel, aber die plain-
Tape*mm-Form ist die laminated default für PT-Series — und das ist was Code+Tests verwenden.Test plan
Kein Code-Pfad betroffen, nur Doku. Markdown-Render visuell prüfen.
Refs #67 Audit-Punkt:
PR #59 — ptouch-integration.md:10