allow implementations to use error codes for automated actions#194
Conversation
|
with the changes on this PR:
so we end up in a situation where different implementations could be aiming for the same while that is hard to avoid without major spec changes, SRI can greatly reduce the room for such scenarios by providing types for commonly-used that will be tackled via stratum-mining/stratum#2142 |
69565f4 to
0c0bdbb
Compare
|
Does this mean an implementation of JDC that wants to have multiple upstreams, will need to implement all upstreams error codes? How should an implementation learn of error codes for a given upstream? Edit: answered on call. clients are responsible for implementing handling of each Upstream's unique implementation. |
|
Some of the issues raised like 'rejecting 100% of your shares' are not necessarily detected by particular error codes, those types of issues could potentially be tracked with lower-level traffic metrics (by adding byte/message count metrics)
|
0c0bdbb to
e071ffd
Compare
|
ok with me |
e071ffd to
3c5d7bb
Compare
as discussed in #165
more specifically, this PR implements suggestion from #165 (comment)