Skip to content

channels_sv2::server::share_accounting keeps track of rejected shares#2149

Merged
plebhash merged 1 commit into
stratum-mining:mainfrom
plebhash:2026-05-08-refine-server-share-accounting
May 18, 2026
Merged

channels_sv2::server::share_accounting keeps track of rejected shares#2149
plebhash merged 1 commit into
stratum-mining:mainfrom
plebhash:2026-05-08-refine-server-share-accounting

Conversation

@plebhash

@plebhash plebhash commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This was referenced May 8, 2026
Closed
Merged
@plebhash
plebhash marked this pull request as ready for review May 8, 2026 22:04
gimballock
gimballock reviewed May 10, 2026
View reviewed changes
Comment thread sv2/channels-sv2/src/server/extended.rs Outdated
@plebhash
plebhash force-pushed the 2026-05-08-refine-server-share-accounting branch from 533ca1e to 47163fb Compare May 11, 2026 22:00
Shourya742
Shourya742 approved these changes May 12, 2026
View reviewed changes

@Shourya742 Shourya742 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

GitGab19
GitGab19 reviewed May 12, 2026
View reviewed changes
Comment thread sv2/channels-sv2/src/server/extended.rs Outdated
Comment thread sv2/channels-sv2/src/server/standard.rs Outdated
@GitGab19 GitGab19 mentioned this pull request May 12, 2026
Closed
@plebhash plebhash mentioned this pull request May 12, 2026
Closed
@plebhash
plebhash marked this pull request as draft May 12, 2026 19:17
@plebhash plebhash mentioned this pull request May 13, 2026
Merged
@plebhash
plebhash force-pushed the 2026-05-08-refine-server-share-accounting branch 6 times, most recently from 253cb84 to d3ede61 Compare May 15, 2026 01:55
@plebhash
plebhash marked this pull request as ready for review May 15, 2026 01:56
@plebhash
plebhash force-pushed the 2026-05-08-refine-server-share-accounting branch from d3ede61 to 5e1b025 Compare May 18, 2026 15:34
@plebhash
plebhash merged commit 9a61b5e into stratum-mining:main May 18, 2026
14 checks passed
@plebhash
plebhash deleted the 2026-05-08-refine-server-share-accounting branch May 18, 2026 16:06
plebhash added a commit that referenced this pull request May 19, 2026
@plebhash
release(v1.8.1): bump publish versions for backported crates
744d57e 
Adaptation commit (not a direct cherry-pick).

Bumps channels_sv2 4.0.0 -> 4.0.1, mining_sv2 8.0.0 -> 8.0.1, and stratum-core 0.2.1 -> 0.2.2 so release/v1.8.1 changes can be published to crates.io.

Related backport sources: 3a7c287 (#2138), ebc7386 (#2139), 5e1b025 (#2149), 3da394f (#2152).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitGab19 GitGab19 GitGab19 approved these changes
@Shourya742 Shourya742 Awaiting requested review from Shourya742
@gimballock gimballock Awaiting requested review from gimballock

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

channels_sv2::server::share_accounting::ShareAccounting needs refinement

4 participants

@plebhash @gimballock @GitGab19 @Shourya742