Skip to content

represent share work as u64 (where appropriate) - #449

Merged
plebhash merged 3 commits into
stratum-mining:mainfrom
plebhash:2026-04-22-share-work-u64
May 18, 2026
Merged

represent share work as u64 (where appropriate)#449
plebhash merged 3 commits into
stratum-mining:mainfrom
plebhash:2026-04-22-share-work-u64

Conversation

@plebhash

@plebhash plebhash commented Apr 22, 2026

Copy link
Copy Markdown
Member

companion stratum-mining/stratum#2138

changes OpenAPI contract:

  • ExtendedChannelInfo.last_batch_work_sum:
    • changes type from number(double) to integer(int64, minimum: 0)
  • StandardChannelInfo.last_batch_work_sum:
    • changes type from number(double) to integer(int64, minimum: 0)
  • ServerExtendedChannelInfo:
    • removed field: share_work_sum
    • added new field: acknowledged_work_sum
    • added new field: validated_work_sum
  • ServerStandardChannelInfo:
    • removed field: share_work_sum
    • added new field: acknowledged_work_sum
    • added new field: validated_work_sum

@plebhash plebhash changed the title represent share work as u64 where appropriate represent share work as u64 (where appropriate) Apr 22, 2026
@plebhash

Copy link
Copy Markdown
Member Author

reverting back to draft, see: stratum-mining/stratum#2092 (comment)

@plebhash
plebhash marked this pull request as draft April 25, 2026 00:07
@plebhash
plebhash force-pushed the 2026-04-22-share-work-u64 branch 2 times, most recently from 11922d8 to 0c02cb1 Compare May 15, 2026 22:41
@plebhash
plebhash requested a review from GitGab19 May 15, 2026 23:56

@GitGab19 GitGab19 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plebhash
plebhash force-pushed the 2026-04-22-share-work-u64 branch from 5411a4a to d502fa4 Compare May 18, 2026 12:19
@plebhash
plebhash force-pushed the 2026-04-22-share-work-u64 branch from d502fa4 to e8615aa Compare May 18, 2026 12:21
@plebhash
plebhash marked this pull request as ready for review May 18, 2026 12:21
@plebhash
plebhash force-pushed the 2026-04-22-share-work-u64 branch from e8615aa to c625de0 Compare May 18, 2026 13:01

@Shourya742 Shourya742 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@plebhash
plebhash merged commit 1ff05ce into stratum-mining:main May 18, 2026
12 checks passed
@plebhash
plebhash deleted the 2026-04-22-share-work-u64 branch May 18, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants