feat(i18n,ocr): add Hebrew UI localization and Hebrew OCR support

.github/workflows/ci.yml

@@ -123,7 +123,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
-      - uses: EmbarkStudios/cargo-deny-action@3c6349835b2b7b196a839186cb8b78e02f7b5f25 # v2.1.1
+      - uses: EmbarkStudios/cargo-deny-action@v2
         with:
           command: check
 

.github/workflows/nix.yml

@@ -18,6 +18,16 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  nix:
-    # Intentionally tracked at @main (not SHA-pinned) so org-wide CI improvements, security fixes, and build optimizations propagate without PR churn across all craftapp repos.
-    uses: storytold/craft-common-actions/.github/workflows/nix.yml@main
+  eval:
+    runs-on: ubuntu-latest
+    timeout-minutes: 15
+    steps:
+      - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+      - uses: cachix/install-nix-action@448cde739abec1eaf0646249e3d25bb8d9bc7702 # v31.11.2
+      - name: nix flake check --no-build
+        run: |
+          if [ -f flake.nix ]; then
+            nix flake check --no-build --all-systems
+          else
+            echo "No flake.nix present in this repository; skipping check."
+          fi

ATTRIBUTION.md

@@ -4,7 +4,7 @@
 
 Every asset PdfCraft includes, bundles or uses to build its published material, with its author, source and licence. The policy is in [AGENTS.md](AGENTS.md) §1. The machine-readable list, with SHA-256 hashes, is [ATTRIBUTION.toml](ATTRIBUTION.toml). Licence texts are kept beside the assets and summarised in [NOTICE](NOTICE).
 
-## In this repository (288)
+## In this repository (289)
 
 | Asset | Title | Author | Licence | Source | Used for |
 |---|---|---|---|---|---|
@@ -35,6 +35,7 @@ Every asset PdfCraft includes, bundles or uses to build its published material,
 | `crates/ui-egui/src/i18n/ko.tsv` | Korean interface translation catalog | PdfCraft contributors | MIT OR Apache-2.0 | Contributor-original: clean-room translations of PdfCraft's English UI labels, no proprietary localisation resources; 2026-10-22 page-gap labels are contributor-original AI-assisted translations from English, not separately native-reviewed; 2026-10-22 text-field-table labels are contributor-original AI-assisted translations from English, not separately native-reviewed | Korean UI strings, compiled in by crates/ui-egui/src/i18n/mod.rs |
 | `crates/ui-egui/src/i18n/ro.tsv` | Romanian interface translation catalog | PdfCraft contributors | MIT OR Apache-2.0 | Contributor-original: clean-room translations of PdfCraft's English UI labels and user-facing messages; AI-assisted and not yet reviewed line by line by a native Romanian speaker; 2026-10-22 page-gap labels are contributor-original AI-assisted translations from English, not separately native-reviewed; 2026-10-22 text-field-table labels are contributor-original AI-assisted translations from English, not separately native-reviewed | Romanian UI strings, compiled in by crates/ui-egui/src/i18n/mod.rs |
 | `crates/ui-egui/src/i18n/fi.tsv` | Finnish interface translation catalog | PdfCraft contributors | MIT OR Apache-2.0 | Contributor-original: AI-assisted (Claude Code) clean-room translations of PdfCraft's English UI labels and user-facing messages; not yet proofread by a native Finnish speaker; 2026-10-22 page-gap labels are contributor-original AI-assisted translations from English, not separately native-reviewed; 2026-10-22 text-field-table labels are contributor-original AI-assisted translations from English, not separately native-reviewed | Finnish UI strings, compiled in by crates/ui-egui/src/i18n/mod.rs |
+| `crates/ui-egui/src/i18n/he.tsv` | Hebrew interface translation catalog | PdfCraft contributors | MIT OR Apache-2.0 | Contributor-original: clean-room translations of PdfCraft's English UI labels, no proprietary localisation resources | Hebrew UI strings, compiled in by crates/ui-egui/src/i18n/mod.rs |
 | `assets/icons/accessibility.svg` | Lucide icon "accessibility" | Lucide Contributors (portions Cole Bemis, Feather) | ISC | https://github.com/lucide-icons/lucide (npm lucide-static 1.49.0, icons/accessibility.svg) | UI icon, embedded via crates/ui-egui/src/icon_data.rs |
 | `assets/icons/align-left.svg` | Lucide icon "align-left" | Lucide Contributors (portions Cole Bemis, Feather) | ISC | https://github.com/lucide-icons/lucide (npm lucide-static 1.49.0, icons/align-left.svg) | UI icon, embedded via crates/ui-egui/src/icon_data.rs |
 | `assets/icons/align-center.svg` | Lucide icon "align-center" | Lucide Contributors (portions Cole Bemis, Feather) | ISC | https://github.com/lucide-icons/lucide (npm lucide-static 1.49.0, icons/align-center.svg) | UI icon, embedded via crates/ui-egui/src/icon_data.rs |

ATTRIBUTION.toml

@@ -306,6 +306,17 @@ kind = "translation"
 usage = "Finnish UI strings, compiled in by crates/ui-egui/src/i18n/mod.rs"
 sha256 = "609efa92054aa76de4bb6062c0fcc0a8b450519f4b253b4c0f395b3cbb34d2ba"
 
+[[asset]]
+path = "crates/ui-egui/src/i18n/he.tsv"
+title = "Hebrew interface translation catalog"
+author = "PdfCraft contributors"
+source = "Contributor-original: clean-room translations of PdfCraft's English UI labels, no proprietary localisation resources"
+licence = "MIT OR Apache-2.0"
+licence_file = "LICENSE-MIT"
+kind = "translation"
+usage = "Hebrew UI strings, compiled in by crates/ui-egui/src/i18n/mod.rs"
+sha256 = "3123ce56cd9367355c9c8c25c01e73ac50022ea7441209bfbd2521ddbab9cc55"
+
 [[asset]]
 path = "assets/icons/accessibility.svg"
 title = "Lucide icon \"accessibility\""

contributors/people.toml

@@ -154,6 +154,10 @@ sync_github_name = false
 display_name = "Netter"
 sync_github_name = false
 
+[people.ronnieba]
+sync_github_name = true
+
+
 [people.MortenHusted]
 sync_github_name = true
 

crates/edit/src/lib.rs

@@ -360,6 +360,9 @@ fn add_resources(doc: &mut Document, page: &pdfcraft_model::Page, opacity: Optio
         }
         faces.push((name.to_vec(), base));
     }
+    if content.is_some_and(|c| c.windows(6).any(|w| w == b"/PCOCR")) {
+        faces.push((b"PCOCR".to_vec(), "PCOCR"));
+    }
     add_page_resources(doc, page, opacity, &faces)
 }
 
@@ -397,13 +400,61 @@ fn add_page_resources(doc: &mut Document, page: &pdfcraft_model::Page, opacity:
     let mut res = page.dict.get(b"Resources").map(|r| doc.resolve(r)).and_then(|r| r.as_dict().cloned()).unwrap_or_default();
     let mut fonts = res.get(b"Font").map(|f| doc.resolve(f)).and_then(|f| f.as_dict().cloned()).unwrap_or_default();
     for (name, base) in faces {
+        if *base == "PCOCR" {
+            continue;
+        }
         let mut font = Dict::new();
         font.set(b"Type".to_vec(), Object::name("Font"));
         font.set(b"Subtype".to_vec(), Object::name("Type1"));
         font.set(b"BaseFont".to_vec(), Object::name(base));
         font.set(b"Encoding".to_vec(), Object::name("WinAnsiEncoding"));
         fonts.set(name.clone(), Object::Dict(font));
     }
+    if faces.iter().any(|(_, base)| *base == "PCOCR") && fonts.get(b"PCOCR").is_none() {
+        let mut cmap_bytes = b"/CIDInit /ProcSet findresource begin\n12 dict begin\nbegincmap\n/CIDSystemInfo << /Registry (Adobe) /Ordering (UCS) /Supplement 0 >> def\n/CMapName /PCOCRUnicode def\n/CMapType 2 def\n1 begincodespacerange\n<0000> <FFFF>\nendcodespacerange\n".to_vec();
+        let highs: Vec<u32> = (0..=0xFFu32).filter(|h| !(0xD8..=0xDF).contains(h)).collect();
+        for chunk in highs.chunks(100) {
+            cmap_bytes.extend(format!("{} beginbfrange\n", chunk.len()).bytes());
+            for h in chunk {
+                cmap_bytes.extend(format!("<{h:02X}00> <{h:02X}FF> <{h:02X}00>\n").bytes());
+            }
+            cmap_bytes.extend(b"endbfrange\n");
+        }
+        cmap_bytes.extend(b"endcmap\nCMapName currentdict /CMap defineresource pop\nend\nend\n");
+        let cmap = doc.add(Object::Stream(Stream::flate(Dict::new(), &cmap_bytes)));
+        let mut desc = Dict::new();
+        desc.set(b"Type".to_vec(), Object::name("FontDescriptor"));
+        desc.set(b"FontName".to_vec(), Object::name("PCOCR"));
+        desc.set(b"Flags".to_vec(), Object::Int(32));
+        desc.set(b"FontBBox".to_vec(), Object::Array(vec![Object::Int(0), Object::Int(-200), Object::Int(1000), Object::Int(800)]));
+        desc.set(b"ItalicAngle".to_vec(), Object::Int(0));
+        desc.set(b"Ascent".to_vec(), Object::Int(800));
+        desc.set(b"Descent".to_vec(), Object::Int(-200));
+        desc.set(b"CapHeight".to_vec(), Object::Int(700));
+        desc.set(b"StemV".to_vec(), Object::Int(80));
+        let desc_ref = doc.add(Object::Dict(desc));
+        let mut sys = Dict::new();
+        sys.set(b"Registry".to_vec(), Object::String(pdfcraft_cos::PdfString::literal(b"Adobe".to_vec())));
+        sys.set(b"Ordering".to_vec(), Object::String(pdfcraft_cos::PdfString::literal(b"Identity".to_vec())));
+        sys.set(b"Supplement".to_vec(), Object::Int(0));
+        let mut cid = Dict::new();
+        cid.set(b"Type".to_vec(), Object::name("Font"));
+        cid.set(b"Subtype".to_vec(), Object::name("CIDFontType2"));
+        cid.set(b"BaseFont".to_vec(), Object::name("PCOCR"));
+        cid.set(b"CIDSystemInfo".to_vec(), Object::Dict(sys));
+        cid.set(b"FontDescriptor".to_vec(), Object::Ref(desc_ref));
+        cid.set(b"DW".to_vec(), Object::Int(500));
+        cid.set(b"CIDToGIDMap".to_vec(), Object::name("Identity"));
+        let cid_ref = doc.add(Object::Dict(cid));
+        let mut font = Dict::new();
+        font.set(b"Type".to_vec(), Object::name("Font"));
+        font.set(b"Subtype".to_vec(), Object::name("Type0"));
+        font.set(b"BaseFont".to_vec(), Object::name("PCOCR"));
+        font.set(b"Encoding".to_vec(), Object::name("Identity-H"));
+        font.set(b"DescendantFonts".to_vec(), Object::Array(vec![Object::Ref(cid_ref)]));
+        font.set(b"ToUnicode".to_vec(), Object::Ref(cmap));
+        fonts.set(b"PCOCR".to_vec(), Object::Dict(font));
+    }
     res.set(b"Font".to_vec(), Object::Dict(fonts));
     if let Some(o) = opacity {
         let mut gs = res.get(b"ExtGState").map(|g| doc.resolve(g)).and_then(|g| g.as_dict().cloned()).unwrap_or_default();

crates/engine/src/dates.rs

@@ -63,7 +63,7 @@ const CKB_DAYS: [&str; 7] = ["یەکشەممە", "دووشەممە", "سێشەم
 
 /// The languages month and weekday names can be written in (Preferences ▸ Date format ▸ Language):
 /// the interface languages, in the same order and with the same names.
-pub static DATE_LANGUAGES: [DateLanguage; 34] = [
+pub static DATE_LANGUAGES: [DateLanguage; 35] = [
     DateLanguage {
         code: "en",
         name: "English",
@@ -564,6 +564,28 @@ pub static DATE_LANGUAGES: [DateLanguage; 34] = [
         days: ["søndag", "mandag", "tirsdag", "onsdag", "torsdag", "fredag", "lørdag"],
         days_short: ["søn.", "man.", "tir.", "ons.", "tor.", "fre.", "lør."],
     },
+    DateLanguage {
+        code: "he",
+        name: "עברית",
+        months: ["ינואר", "פברואר", "מרץ", "אפריל", "מאי", "יוני", "יולי", "אוגוסט", "ספטמבר", "אוקטובר", "נובמבר", "דצמבר"],
+        months_with_day: Some([
+            "בינואר",
+            "בפברואר",
+            "במרץ",
+            "באפריל",
+            "במאי",
+            "ביוני",
+            "ביולי",
+            "באוגוסט",
+            "בספטמבר",
+            "באוקטובר",
+            "בנובמבר",
+            "בדצמבר",
+        ]),
+        months_short: ["ינו׳", "פבר׳", "מרץ", "אפר׳", "מאי", "יוני", "יולי", "אוג׳", "ספט׳", "אוק׳", "נוב׳", "דצמ׳"],
+        days: ["יום ראשון", "יום שני", "יום שלישי", "יום רביעי", "יום חמישי", "יום שישי", "יום שבת"],
+        days_short: ["א׳", "ב׳", "ג׳", "ד׳", "ה׳", "ו׳", "ש׳"],
+    },
 ];
 
 /// The date language for `code` (any case), or `None` when there's none.
@@ -989,6 +1011,19 @@ mod tests {
         assert!(s.today_text_for_pdf(Some("dd.mm.yyyy"), Some("vi")).is_ok());
     }
 
+    #[test]
+    fn hebrew_month_and_weekday_names() {
+        let mut s = Session::new().with_clock(|| 1_700_000_000);
+        s.set_date_language(Some("HE")).unwrap();
+        assert_eq!(s.date_language(), Some("he"));
+        s.set_date_format("d mmmm yyyy").unwrap();
+        assert_eq!(s.today_text(None, None).as_deref(), Ok("14 בנובמבר 2023"));
+        s.set_date_format("mmmm yyyy").unwrap();
+        assert_eq!(s.today_text(None, None).as_deref(), Ok("נובמבר 2023"));
+        s.set_date_format("dddd, d mmm").unwrap();
+        assert_eq!(s.today_text(None, None).as_deref(), Ok("יום שלישי, 14 נוב׳"));
+    }
+
     #[test]
     fn dates_the_pdf_cannot_hold_are_refused_not_damaged() {
         assert_eq!(unwritable("8. října 2026"), "ř");

crates/engine/src/ocr.rs

@@ -130,7 +130,7 @@ impl OcrJob {
                 out.push(skip(&e));
                 continue;
             }
-            let lines = match ocr.recognize(&shot.rgba, shot.width, shot.height) {
+            let lines = match ocr.recognize_lang(&shot.rgba, shot.width, shot.height, &self.settings.language) {
                 Ok(l) => l,
                 Err(e) => {
                     out.push(skip(&e.to_string()));

crates/engine/tests/it/ocr_edit.rs

@@ -207,3 +207,20 @@ fn visible_stretched_text_rewrites_unchanged() {
     let i = ((y * out.width + x) * 4) as usize;
     assert_eq!(&out.rgba[i..i + 3], &[255, 255, 255]);
 }
+
+#[test]
+fn hebrew_ocr_words_are_searchable_in_logical_order() {
+    // On an RTL line, "שלום" sits on the right (x = 120..160) and "עולם" on the left (x = 60..100).
+    let (s, id) = scanned_with(vec![word("שלום", 120.0, 160.0, 50.0), word("עולם", 60.0, 100.0, 50.0)]);
+    let doc = s.get(id).unwrap();
+    let out = PageRenderer::new(doc.bytes.clone(), Default::default()).render(RenderRequest {
+        page: 0,
+        kind: pdfcraft_render::RequestKind::Text,
+        scale: 1.0,
+        ..Default::default()
+    });
+    let page_text = out.text.expect("page text extracted");
+    assert_eq!(page_text.plain_text().trim(), "שלום עולם");
+    assert!(!page_text.find("שלום").is_empty());
+    assert!(!page_text.find("עולם").is_empty());
+}