-
Notifications
You must be signed in to change notification settings - Fork 22
Remove play button from sidebar #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yannbf
wants to merge
13
commits into
main
Choose a base branch
from
upgrade-storybook-v10
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,949
−7,050
Open
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ed3b684
Remove play button from sidebar
yannbf 8cfddfa
upgrade to Storybook 9
yannbf 84501be
upgrade to Storybook 10
yannbf 2db970c
add mobile stories
yannbf 9faa246
migrate to nextjs vite
yannbf e830036
remove unnecessary import
yannbf 7957fbc
migrate nextjs config to ESM
yannbf 47a0155
Generate redirects before building Storybook
kylegach 3a0301a
Merge branch 'main' into upgrade-storybook-v10
kylegach b2a1d4e
Accommodate animation flake
kylegach 7c8c9ee
Threshold tweak
kylegach 510feb0
Merge branch 'main' into upgrade-storybook-v10
kylegach de3f769
Merge branch 'main' into upgrade-storybook-v10
Sidnioulz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
apps/frontpage/components/docs/mdx/code-snippets/code-snippets.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
apps/frontpage/components/home/manager/manager.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| import { Manager } from './index'; | ||
|
|
||
| export default { | ||
| title: 'Manager', | ||
| component: Manager, | ||
| parameters: { | ||
| layout: 'fullscreen', | ||
| chromatic: { | ||
| diffThreshold: 0.3, // Accommodate animation flake | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| export const DevelopmentTab = { | ||
| args: { | ||
| slide: 1, | ||
| }, | ||
| } | ||
|
|
||
| export const InteractionTab = { | ||
| args: { | ||
| slide: 2, | ||
| } | ||
| } | ||
|
|
||
| export const VisualTestingTab = { | ||
| args: { | ||
| slide: 3, | ||
| } | ||
| } | ||
|
|
||
| export const DocumentationTab = { | ||
| args: { | ||
| slide: 4, | ||
| } | ||
| } | ||
|
|
||
| export const DevelopmentTabMobile = { | ||
| ...DevelopmentTab, | ||
| globals: { | ||
| viewport: { value: 'mobile1', isRotated: false }, | ||
| }, | ||
| } | ||
|
|
||
| export const InteractionTabMobile = { | ||
| ...InteractionTab, | ||
| globals: { | ||
| viewport: { value: 'mobile1', isRotated: false }, | ||
| }, | ||
| } | ||
|
|
||
|
|
||
| export const VisualTestingTabMobile = { | ||
| ...VisualTestingTab, | ||
| globals: { | ||
| viewport: { value: 'mobile1', isRotated: false }, | ||
| }, | ||
| } | ||
|
|
||
| export const DocumentationTabMobile = { | ||
| ...DocumentationTab, | ||
| globals: { | ||
| viewport: { value: 'mobile1', isRotated: false }, | ||
| }, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -12,7 +12,7 @@ | |||||
| "generate-redirects": "tsx --tsconfig tsconfig.json scripts/generate-redirects.ts", | ||||||
| "clean": "rm -rf .turbo && rm -rf node_modules && rm -rf .next", | ||||||
| "storybook": "storybook dev -p 6006", | ||||||
| "build-storybook": "storybook build", | ||||||
| "build-storybook": "npm run generate-redirects && storybook build", | ||||||
| "chromatic": "npx chromatic --project-token=chpt_34c705b51a7f543", | ||||||
| "test": "vitest" | ||||||
| }, | ||||||
|
|
@@ -66,19 +66,13 @@ | |||||
| "zod": "^3.23.8" | ||||||
| }, | ||||||
| "devDependencies": { | ||||||
| "@chromatic-com/storybook": "^1.4.0", | ||||||
| "@chromatic-com/storybook": "^4.2.0-next.1", | ||||||
| "@next/eslint-plugin-next": "^14.1.1", | ||||||
| "@repo/eslint-config": "*", | ||||||
| "@repo/tailwind-config": "*", | ||||||
| "@repo/typescript-config": "*", | ||||||
| "@storybook/addon-essentials": "^8.1.1", | ||||||
| "@storybook/addon-interactions": "^8.1.1", | ||||||
| "@storybook/addon-links": "^8.1.1", | ||||||
| "@storybook/blocks": "^8.1.1", | ||||||
| "@storybook/nextjs": "^8.1.1", | ||||||
| "@storybook/preview-api": "^8.1.1", | ||||||
| "@storybook/react": "^8.1.1", | ||||||
| "@storybook/test": "^8.1.1", | ||||||
| "@storybook/addon-links": "^10.0.0-beta.10", | ||||||
| "@storybook/nextjs-vite": "^10.0.0-beta.10", | ||||||
| "@testing-library/react": "^16.0.0", | ||||||
| "@types/fs-extra": "^11.0.4", | ||||||
| "@types/node": "^20", | ||||||
|
|
@@ -88,14 +82,15 @@ | |||||
| "@types/react-syntax-highlighter": "^15.5.12", | ||||||
| "@types/tar": "^6.1.13", | ||||||
| "@vitejs/plugin-react": "^4.3.0", | ||||||
| "eslint-plugin-storybook": "^0.8.0", | ||||||
| "eslint-plugin-storybook": "^10.0.0-beta.10", | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| "jsdom": "^24.1.0", | ||||||
| "postcss": "^8", | ||||||
| "prompts": "^2.4.2", | ||||||
| "storybook": "^8.1.1", | ||||||
| "storybook": "^10.0.0-beta.10", | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| "tailwindcss": "^3.4.1", | ||||||
| "tsx": "^4.9.0", | ||||||
| "typescript": "^5.3.3", | ||||||
| "vitest": "^1.6.0" | ||||||
| "vitest": "^1.6.0", | ||||||
| "@storybook/addon-docs": "^10.0.0-beta.10" | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| } | ||||||
| } | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.