Remove play button from sidebar #332
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for storybook-addon-catalog failed. Why did it fail? →
|
❌ Deploy Preview for storybook-frontpage failed. Why did it fail? →
|
kylegach
force-pushed
the
upgrade-storybook-v10
branch
from
0c37f34 to
b2a1d4e
Compare
Sidnioulz
approved these changes
Nov 14, 2025
Member
Sidnioulz
left a comment
Sidnioulz
left a comment
There was a problem hiding this comment.
LGTM. We can now update deps to 10.0, I've set suggestions to make it easier.
Comment on lines
+74
to
+75
| "@storybook/addon-links": "^10.0.0-beta.10", | ||
| "@storybook/nextjs-vite": "^10.0.0-beta.10", |
Member
There was a problem hiding this comment.
Suggested change
| "@storybook/addon-links": "^10.0.0-beta.10", | |
| "@storybook/nextjs-vite": "^10.0.0-beta.10", | |
| "@storybook/addon-links": "^10.0.0", | |
| "@storybook/nextjs-vite": "^10.0.0", |
| "@types/tar": "^6.1.13", | ||
| "@vitejs/plugin-react": "^4.3.0", | ||
| "eslint-plugin-storybook": "^0.8.0", | ||
| "eslint-plugin-storybook": "^10.0.0-beta.10", |
Member
There was a problem hiding this comment.
Suggested change
| "eslint-plugin-storybook": "^10.0.0-beta.10", | |
| "eslint-plugin-storybook": "^10.0.0", |
| "postcss": "^8", | ||
| "prompts": "^2.4.2", | ||
| "storybook": "^8.1.1", | ||
| "storybook": "^10.0.0-beta.10", |
Member
There was a problem hiding this comment.
Suggested change
| "storybook": "^10.0.0-beta.10", | |
| "storybook": "^10.0.0", |
| "typescript": "^5.3.3", | ||
| "vitest": "^1.6.0" | ||
| "vitest": "^1.6.0", | ||
| "@storybook/addon-docs": "^10.0.0-beta.10" |
Member
There was a problem hiding this comment.
Suggested change
| "@storybook/addon-docs": "^10.0.0-beta.10" | |
| "@storybook/addon-docs": "^10.0.0" |
Comment on lines
+47
to
+48
| "@storybook/addon-themes": "^10.0.0-beta.10", | ||
| "@storybook/nextjs-vite": "^10.0.0-beta.10", |
Member
There was a problem hiding this comment.
Suggested change
| "@storybook/addon-themes": "^10.0.0-beta.10", | |
| "@storybook/nextjs-vite": "^10.0.0-beta.10", | |
| "@storybook/addon-themes": "^10.0.0", | |
| "@storybook/nextjs-vite": "^10.0.0", |
| "autoprefixer": "^10.4.18", | ||
| "eslint": "^8.57.0", | ||
| "eslint-plugin-storybook": "^0.11.1", | ||
| "eslint-plugin-storybook": "^10.0.0-beta.10", |
Member
There was a problem hiding this comment.
Suggested change
| "eslint-plugin-storybook": "^10.0.0-beta.10", | |
| "eslint-plugin-storybook": "^10.0.0", |
| "postcss": "^8.4.35", | ||
| "react": "^18.2.0", | ||
| "storybook": "^8.4.5", | ||
| "storybook": "^10.0.0-beta.10", |
Member
There was a problem hiding this comment.
Suggested change
| "storybook": "^10.0.0-beta.10", | |
| "storybook": "^10.0.0", |
| "tailwindcss": "^3.4.1", | ||
| "typescript": "^5.3.3" | ||
| "typescript": "^5.3.3", | ||
| "@storybook/addon-docs": "^10.0.0-beta.10" |
Member
There was a problem hiding this comment.
Suggested change
| "@storybook/addon-docs": "^10.0.0-beta.10" | |
| "@storybook/addon-docs": "^10.0.0" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the "play" button from the animated layout used in frontpage, and also upgrades from Storybook 8 -> 10. Additionally, sets Storybook to use the nextjs-vite framework.
Before:
After:
