-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(story): add authentication #9
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
1e495ea
to
e099f47
Compare
fce969d
to
fb5ab32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This middleware approach is really cool and better, compared with what we had before.
@eunjae-lee, is there any chance of this one in particular not being reachable because the story-starter/starters/nuxt/server/middleware/auth.ts
would take precedence over this one?
I'm wondering if the auth is going to be executed first and if so, may this one will never be reachable.
Do you think there is this chance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@demetriusfeijoo good point!
I've renamed them according to this rule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort in this one, @eunjae-lee. 🚀
@BibiSebi @demetriusfeijoo by the way, I'm not going to merge this PR and its parent PR. We're going to stack more PRs on top of this, and try to merge them altogether via Graphite. So, don't merge this by accident! :) |
Merge activity
|
48e90f7
to
7c03b6d
Compare
What?
This PR adds oauth flow.
Find more explanation at https://storyblok.slack.com/archives/C04P3JBHWHW/p1697208267013089
Why?
JIRA: EXT-1994
How to test? (optional)