chore(story): clean up project settings #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
commented
Oct 13, 2023
Comment on lines
+20
to
+21
| "vue": "^3.3.4", | ||
| "vue-router": "^4.2.5" |
There was a problem hiding this comment.
I added this two dependencies, because nuxt had problem with pnpm workspaces. It wasn't able to resolve vue and vue-router. We need to add this two dev dependencies explicitly.
FYI, we created this project by running npx nuxi@latest init <app-name>. I ran it again today in a different folder and the latest version of their template included these.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
eunjae-lee
requested review from
a team,
demetriusfeijoo and
BibiSebi
and removed request for
a team and
demetriusfeijoo
BibiSebi
approved these changes
Oct 16, 2023
This was referenced Oct 23, 2023
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR cleans up the project settings. More details in the comments.
How to test? (optional)