-
Notifications
You must be signed in to change notification settings - Fork 3
Add a dedicated Vendor Asset class #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
These methods aren't applicable to this class
574f9f8 to
113fc17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the minor syntax comment - i like the work.
Going to ask @borkweb to take a look as well when he can before we merge though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just though that we would need to change the static method
Asset::add - to add a new static and not a new self!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some docblock tweaks.
Overall looks good.
Agree with Dimi on the new static
This adds the
VendorAssetclass for use with vendor scripts. The specific uses case is when handling a 3rd-party asset and registering a CDN URL for the asset instead of a local URL.Notable changes:
VendorAssetclass as an extension of theAssetclass.wpunittest suite to test various aspects ofVendorAsset.Assetclass.