Add a dedicated Vendor Asset class

src/Assets/Asset.php

@@ -78,28 +78,28 @@ class Asset {
 	protected array $groups = [];
 
 	/**
-	 * Should the asset be loaded in the footer?
+	 * Whether the asset should be loaded in the footer.
 	 *
 	 * @var bool
 	 */
 	protected bool $in_footer = true;
 
 	/**
-	 * Should the asset be marked as async?
+	 * Whether the asset should be marked as async.
 	 *
 	 * @var bool
 	 */
 	protected bool $is_async = false;
 
 	/**
-	 * Should the asset be marked as deferred?
+	 * Whether the asset should be marked as deferred.
 	 *
 	 * @var bool
 	 */
 	protected bool $is_deferred = false;
 
 	/**
-	 * Is the asset enqueued?
+	 * Whether the asset has been enqueued.
 	 *
 	 * @var bool
 	 */
@@ -113,21 +113,21 @@ class Asset {
 	protected bool $is_module = false;
 
 	/**
-	 * Is the asset printed?
+	 * Whether the asset has been printed.
 	 *
 	 * @var bool
 	 */
 	protected bool $is_printed = false;
 
 	/**
-	 * Is the asset registered?
+	 * Whether the asset has been registered.
 	 *
 	 * @var bool
 	 */
 	protected bool $is_registered = false;
 
 	/**
-	 * Is the asset a vendor asset?
+	 * Whether this is a vendor asset.
 	 *
 	 * @var bool
 	 */
@@ -344,6 +344,8 @@ public function add_to_group_path( string $group_path_name ) {
 	 * @param string      $file      The asset file path.
 	 * @param string|null $version   The asset version.
 	 * @param string|null $root_path The path to the root of the plugin.
+	 *
+	 * @return self
 	 */
 	public static function add( string $slug, string $file, string $version = null, $root_path = null ) {
 		return Assets::init()->add( new self( $slug, $file, $version, $root_path ) );
@@ -534,7 +536,7 @@ protected function build_asset_url(): string {
 		$url = $plugin_base_url . $resource_path . $resource;
 
 		/**
-		 * Filters the asset URL
+		 * Filters the asset URL.
 		 *
 		 * @param string $url   Asset URL.
 		 * @param string $slug  Asset slug.
@@ -681,11 +683,11 @@ public function clone_to( string $clone_type, ...$dependencies ) {
 		$source_type = $this->get_type();
 
 		if ( $clone_type === $source_type ) {
-			throw new \InvalidArgumentException( 'The clone type must be different from the source type.' );
+			throw new InvalidArgumentException( 'The clone type must be different from the source type.' );
 		}
 
 		if ( ! in_array( $clone_type, [ 'css', 'js' ], true ) ) {
-			throw new \InvalidArgumentException( 'The clone type must be either "css" or "js".' );
+			throw new InvalidArgumentException( 'The clone type must be either "css" or "js".' );
 		}
 
 		$slug  = $this->slug;

src/Assets/Assets.php

@@ -109,22 +109,21 @@ public static function asset( string $slug, string $file, string $version = null
 	 *
 	 * @param Asset $asset Register an asset.
 	 *
-	 * @return Asset|false The registered object or false on error.
+	 * @return Asset|VendorAsset The registered object.
 	 * @since 1.0.0
 	 *
 	 */
 	public function add( Asset $asset ) {
-		// Prevent weird stuff here.
+		// Check if the slug is registered, and if so return the previously-registered Asset.
 		$slug = $asset->get_slug();
 
 		if ( $this->exists( $slug ) ) {
 			return $this->get( $slug );
 		}
 
-		// Set the Asset on the array of notices.
+		// Add the asset to the array of assets.
 		$this->assets[ $slug ] = $asset;
 
-		// Return the Slug because it might be modified.
 		return $asset;
 	}
 
@@ -193,7 +192,7 @@ public function filter_print_before_after_script( $tag, $handle ): string {
 	 * @param string|array $slug Slug of the Asset.
 	 * @param boolean $sort If we should do any sorting before returning.
 	 *
-	 * @return array|Asset Array of asset objects, single asset object, or null if looking for a single asset but
+	 * @return array|Asset|VendorAsset Array of asset objects, single asset object, or null if looking for a single asset but
 	 *                           it was not in the array of objects.
 	 * @since 1.0.0
 	 *