Skip to content

Conversation

@igor-sirotin
Copy link
Collaborator

Description

With #7080 there's too many adapters now.
Extracted to a sub-package.

@status-im-auto
Copy link
Member

status-im-auto commented Nov 14, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a493f85 #1 2025-11-14 10:28:16 ~4 min macos/status-go 📦zip
✔️ a493f85 #1 2025-11-14 10:29:29 ~6 min windows/status-go 📦zip
✔️ a493f85 #1 2025-11-14 10:30:25 ~7 min linux/status-go 📦zip
✔️ a493f85 #1 2025-11-14 10:41:59 ~18 min linux/nwaku 📦zip
✔️ a493f85 #1 2025-11-14 10:48:40 ~25 min tests-rpc 📄log
✔️ a493f85 #1 2025-11-14 11:04:52 ~41 min tests 📄log
✔️ c163256 #2 2025-11-14 19:57:22 ~3 min macos/status-go 📦zip
✔️ c163256 #2 2025-11-14 19:57:53 ~3 min linux/status-go 📦zip
✔️ c163256 #2 2025-11-14 19:59:42 ~5 min windows/status-go 📦zip
✔️ c163256 #3 2025-11-14 20:01:49 ~3 min linux/status-go 📦zip
✔️ c163256 #2 2025-11-14 20:04:58 ~10 min linux/nwaku 📦zip
✖️ c163256 #2 2025-11-14 20:08:08 ~14 min tests-rpc 📄log
✔️ c163256 #3 2025-11-14 20:15:36 ~10 min linux/nwaku 📦zip
✔️ c163256 #2 2025-11-14 20:23:29 ~29 min tests 📄log
✔️ c163256 #3 2025-11-14 23:37:04 ~12 min tests-rpc 📄log

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 48.14815% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.79%. Comparing base (063580a) to head (c163256).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
node/adapters/sharedurls.go 42.85% 7 Missing and 1 partial ⚠️
node/adapters/newsfeed.go 44.44% 5 Missing ⚠️
node/status_node_services.go 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (48.14%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7108      +/-   ##
===========================================
+ Coverage    59.27%   59.79%   +0.52%     
===========================================
  Files          804      805       +1     
  Lines       113876   113876              
===========================================
+ Hits         67499    68097     +598     
+ Misses       39481    38837     -644     
- Partials      6896     6942      +46     
Flag Coverage Δ
functional 35.01% <48.14%> (+1.05%) ⬆️
unit 55.42% <40.74%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/geth_backend.go 51.75% <100.00%> (ø)
node/status_node_services.go 77.40% <50.00%> (ø)
node/adapters/newsfeed.go 44.44% <44.44%> (ø)
node/adapters/sharedurls.go 42.85% <42.85%> (ø)

... and 56 files with indirect coverage changes

@igor-sirotin igor-sirotin force-pushed the refactor/node-adapters-subpackage branch from d77c975 to c163256 Compare November 14, 2025 19:53
@igor-sirotin igor-sirotin merged commit 31ee5c9 into develop Nov 15, 2025
20 of 21 checks passed
@igor-sirotin igor-sirotin deleted the refactor/node-adapters-subpackage branch November 15, 2025 13:16
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants