Skip to content

Conversation

@igor-sirotin
Copy link
Collaborator

@igor-sirotin igor-sirotin commented Nov 8, 2025

Closes #7123

Requires:

Description

Extracted Link Preview service from protocol package.

@status-im-auto
Copy link
Member

status-im-auto commented Nov 8, 2025

Jenkins Builds

Click to see older builds (42)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 45ccfcb #1 2025-11-08 17:33:56 ~3 min macos/status-go 📦zip
✔️ 45ccfcb #1 2025-11-08 17:34:56 ~4 min windows/status-go 📦zip
✔️ 45ccfcb #1 2025-11-08 17:43:30 ~13 min linux/status-go 📦zip
✖️ 45ccfcb #1 2025-11-08 17:49:01 ~18 min tests 📄log
✔️ 45ccfcb #1 2025-11-08 17:52:11 ~21 min linux/nwaku 📦zip
✔️ 45ccfcb #1 2025-11-08 17:52:53 ~22 min tests-rpc 📄log
✔️ 9d22b3b #2 2025-11-08 21:43:20 ~3 min linux/status-go 📦zip
✔️ 9d22b3b #2 2025-11-08 21:43:31 ~3 min macos/status-go 📦zip
✔️ 9d22b3b #2 2025-11-08 21:44:30 ~4 min windows/status-go 📦zip
✖️ 9d22b3b #2 2025-11-08 21:45:46 ~5 min tests 📄log
✔️ 9d22b3b #3 2025-11-08 21:46:56 ~3 min macos/status-go 📦zip
✔️ 9d22b3b #3 2025-11-08 21:47:02 ~3 min linux/status-go 📦zip
✔️ 9d22b3b #3 2025-11-08 21:49:59 ~5 min windows/status-go 📦zip
✔️ 9d22b3b #2 2025-11-08 21:51:28 ~11 min linux/nwaku 📦zip
✔️ 9d22b3b #2 2025-11-08 21:51:39 ~11 min tests-rpc 📄log
✖️ 9d22b3b #3 2025-11-08 21:52:22 ~6 min tests 📄log
✔️ b4cc294 #4 2025-11-08 21:51:00 ~3 min macos/status-go 📦zip
✔️ b4cc294 #4 2025-11-08 21:51:32 ~4 min linux/status-go 📦zip
✔️ b4cc294 #4 2025-11-08 21:54:38 ~4 min windows/status-go 📦zip
✖️ b4cc294 #4 2025-11-08 21:59:20 ~6 min tests 📄log
✔️ b4cc294 #3 2025-11-08 22:03:38 ~12 min linux/nwaku 📦zip
✖️ b4cc294 #3 2025-11-08 22:04:31 ~12 min tests-rpc 📄log
✔️ b4cc294 #4 2025-11-09 21:50:14 ~11 min tests-rpc 📄log
✔️ b4cc294 #5 2025-11-12 16:35:13 ~3 min macos/status-go 📦zip
✔️ b4cc294 #5 2025-11-12 16:36:17 ~4 min linux/status-go 📦zip
✔️ b4cc294 #5 2025-11-12 16:36:23 ~4 min windows/status-go 📦zip
✖️ b4cc294 #5 2025-11-12 16:41:14 ~9 min tests 📄log
✔️ b4cc294 #4 2025-11-12 16:43:33 ~11 min linux/nwaku 📦zip
✔️ b4cc294 #5 2025-11-12 16:45:48 ~14 min tests-rpc 📄log
✔️ 0eb6bbf #6 2025-11-13 16:06:42 ~3 min linux/status-go 📦zip
✔️ 0eb6bbf #6 2025-11-13 16:06:55 ~4 min macos/status-go 📦zip
✖️ 0eb6bbf #6 2025-11-13 16:07:42 ~4 min tests 📄log
✔️ 0eb6bbf #6 2025-11-13 16:08:33 ~5 min windows/status-go 📦zip
✔️ 0eb6bbf #5 2025-11-13 16:14:04 ~11 min linux/nwaku 📦zip
✖️ 0eb6bbf #6 2025-11-13 16:35:06 ~32 min tests-rpc 📄log
✔️ cc010b8 #7 2025-11-14 10:02:49 ~3 min linux/status-go 📦zip
✔️ cc010b8 #7 2025-11-14 10:02:55 ~3 min macos/status-go 📦zip
✔️ cc010b8 #7 2025-11-14 10:04:02 ~4 min windows/status-go 📦zip
✖️ cc010b8 #7 2025-11-14 10:04:49 ~5 min tests 📄log
✔️ cc010b8 #6 2025-11-14 10:10:20 ~11 min linux/nwaku 📦zip
✔️ cc010b8 #7 2025-11-14 10:11:50 ~12 min tests-rpc 📄log
✔️ cc010b8 #8 2025-11-14 11:06:23 ~42 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6453ec6 #8 2025-11-17 11:31:26 ~3 min macos/status-go 📦zip
✔️ 6453ec6 #8 2025-11-17 11:31:32 ~3 min linux/status-go 📦zip
✔️ 6453ec6 #8 2025-11-17 11:32:26 ~4 min windows/status-go 📦zip
✔️ 6453ec6 #7 2025-11-17 11:39:12 ~11 min linux/nwaku 📦zip
✔️ 6453ec6 #8 2025-11-17 11:40:30 ~12 min tests-rpc 📄log
✔️ 6453ec6 #9 2025-11-17 11:55:13 ~27 min tests 📄log
✔️ 77e680d #9 2025-11-19 23:40:37 ~3 min linux/status-go 📦zip
✔️ 77e680d #9 2025-11-19 23:40:43 ~3 min macos/status-go 📦zip
✔️ 77e680d #9 2025-11-19 23:41:04 ~4 min windows/status-go 📦zip
✔️ 77e680d #8 2025-11-19 23:48:26 ~11 min linux/nwaku 📦zip
✔️ 77e680d #9 2025-11-19 23:49:44 ~12 min tests-rpc 📄log
✔️ 77e680d #10 2025-11-20 00:03:11 ~26 min tests 📄log

@igor-sirotin igor-sirotin force-pushed the chore/extract-linkpreview-service branch from 45ccfcb to 9d22b3b Compare November 8, 2025 21:39
@igor-sirotin igor-sirotin changed the base branch from develop to refactor/t-utils-testconfig November 8, 2025 21:39
Base automatically changed from refactor/t-utils-testconfig to develop November 12, 2025 16:31
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 61.11111% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.84%. Comparing base (8100997) to head (77e680d).

Files with missing lines Patch % Lines
node/adapters/linkpreview.go 25.80% 23 Missing ⚠️
services/linkpreview/service.go 68.75% 10 Missing ⚠️
services/linkpreview/api.go 0.00% 4 Missing ⚠️
services/linkpreview/unfurlers/unfurler_status.go 60.00% 3 Missing and 1 partial ⚠️
services/linkpreview/link_preview.go 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7080      +/-   ##
===========================================
+ Coverage    59.79%   59.84%   +0.05%     
===========================================
  Files          813      816       +3     
  Lines       113989   114028      +39     
===========================================
+ Hits         68156    68242      +86     
+ Misses       38873    38832      -41     
+ Partials      6960     6954       -6     
Flag Coverage Δ
functional 35.00% <40.74%> (+0.05%) ⬆️
unit 55.49% <61.11%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/geth_backend.go 51.78% <100.00%> (+0.02%) ⬆️
node/get_status_node.go 67.55% <ø> (ø)
node/status_node_services.go 78.06% <100.00%> (+0.65%) ⬆️
protocol/requests/create_community_request.go 61.97% <ø> (ø)
services/ext/api.go 34.45% <ø> (+0.27%) ⬆️
services/linkpreview/unfurlers/unfurler.go 71.87% <ø> (ø)
services/linkpreview/unfurlers/unfurler_image.go 59.32% <ø> (ø)
services/linkpreview/unfurlers/unfurler_oembed.go 66.66% <100.00%> (ø)
...rvices/linkpreview/unfurlers/unfurler_opengraph.go 82.47% <ø> (ø)
services/sharedurls/providers.go 0.00% <ø> (ø)
... and 6 more

... and 37 files with indirect coverage changes

@igor-sirotin igor-sirotin force-pushed the chore/extract-linkpreview-service branch 2 times, most recently from 0eb6bbf to cc010b8 Compare November 14, 2025 09:58
@igor-sirotin igor-sirotin force-pushed the chore/extract-linkpreview-service branch from cc010b8 to 6453ec6 Compare November 17, 2025 11:27
@igor-sirotin igor-sirotin marked this pull request as ready for review November 17, 2025 12:15
@igor-sirotin igor-sirotin marked this pull request as draft November 17, 2025 12:16
@igor-sirotin igor-sirotin force-pushed the chore/extract-linkpreview-service branch from 6453ec6 to 77e680d Compare November 19, 2025 23:36
@igor-sirotin igor-sirotin marked this pull request as ready for review November 20, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract linkpreview service

2 participants