-
Notifications
You must be signed in to change notification settings - Fork 265
refactor: extract linkpreview service #7080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
igor-sirotin
wants to merge
8
commits into
develop
Choose a base branch
from
chore/extract-linkpreview-service
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+552
−455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (42)
|
45ccfcb to
9d22b3b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #7080 +/- ##
===========================================
+ Coverage 59.79% 59.84% +0.05%
===========================================
Files 813 816 +3
Lines 113989 114028 +39
===========================================
+ Hits 68156 68242 +86
+ Misses 38873 38832 -41
+ Partials 6960 6954 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
0eb6bbf to
cc010b8
Compare
Merged
cc010b8 to
6453ec6
Compare
6453ec6 to
77e680d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7123
Requires:
retrieveWalletBalancesfrom Messenger #7106Description
Extracted Link Preview service from
protocolpackage.