chore: drop status go ethereum fork #6961
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlipicar
changed the base branch from
develop
to
feat/replace-old-transfer-detector
dlipicar
changed the title
Jenkins BuildsClick to see older builds (94)
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6961 +/- ##
===========================================
+ Coverage 55.44% 59.39% +3.94%
===========================================
Files 833 823 -10
Lines 120101 116697 -3404
===========================================
+ Hits 66595 69315 +2720
+ Misses 46535 40274 -6261
- Partials 6971 7108 +137
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dlipicar
force-pushed
the
feat/replace-old-transfer-detector
branch
3 times, most recently
from
c020188 to
bd4386a
Compare
dlipicar
force-pushed
the
chore/drop-status-go-ethereum-fork
branch
from
64516e8 to
391a815
Compare
dlipicar
force-pushed
the
feat/replace-old-transfer-detector
branch
from
bd4386a to
d064ce0
Compare
dlipicar
force-pushed
the
chore/drop-status-go-ethereum-fork
branch
from
2f71258 to
79d2d46
Compare
dlipicar
force-pushed
the
feat/replace-old-transfer-detector
branch
3 times, most recently
from
c89a9ca to
c7fcae5
Compare
dlipicar
force-pushed
the
chore/drop-status-go-ethereum-fork
branch
from
79d2d46 to
17f7c1a
Compare
dlipicar
force-pushed
the
feat/replace-old-transfer-detector
branch
from
c7fcae5 to
ba10eaa
Compare
|
I've checked once again the status-go/services/ext/service.go Line 354 in 7c3969b That verifies transactions from status-go/protocol/persistence.go Line 1024 in e221047 When do we save to
|
dlipicar
force-pushed
the
feat/replace-old-transfer-detector
branch
from
ba10eaa to
6b24327
Compare
dlipicar
force-pushed
the
chore/drop-status-go-ethereum-fork
branch
from
17f7c1a to
3e24920
Compare
dlipicar
force-pushed
the
feat/replace-old-transfer-detector
branch
from
6b24327 to
6637db7
Compare
dlipicar
force-pushed
the
chore/drop-status-go-ethereum-fork
branch
from
c7a8bfa to
0ec75ce
Compare
dlipicar
force-pushed
the
feat/replace-old-transfer-detector
branch
2 times, most recently
from
a1c4195 to
c9ab1fe
Compare
dlipicar
force-pushed
the
chore/drop-status-go-ethereum-fork
branch
from
0ec75ce to
5029829
Compare
dlipicar
force-pushed
the
chore/drop-status-go-ethereum-fork
branch
from
c7131e1 to
a54b7fb
Compare
* chore: upgrade go-waku and go-discover * chore: make vendor * feat: go-waku v0.10.0
dlipicar
force-pushed
the
chore/drop-status-go-ethereum-fork
branch
from
a54b7fb to
241278c
Compare
siddarthkay
approved these changes
Oct 6, 2025
jakubgs
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
status-desktop PR for testing: status-im/status-desktop#18960
Blocked by:
go-wakuwith upstreamgo-ethereum#6978This PR drops use of our infamous go-ethereum fork (https://github.com/status-im/go-ethereum).
status-go will after this be using the original one (https://github.com/ethereum/go-ethereum).
Much work was done by many folks to get status-go to a state where it stops relying on our changes on top of the go-ethereum version we used as base: ethereum/go-ethereum@master...status-im:go-ethereum:release/v1.10.25-status
Much additional work was done to adapt to the changes between geth v1.10.25 and v1.16.3
This PR includes the final changes missing which mostly cannot be introduced without changing the geth version at the same time.