feat: replace old transfer detector #6960
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (75)
|
dlipicar
changed the title
dlipicar
force-pushed
the
feat/replace-old-transfer-detector
branch
from
4e84983 to
8f2d9a3
Compare
dlipicar
force-pushed
the
feat/introduce-transferdetector-package
branch
2 times, most recently
from
847ac64 to
f046a1d
Compare
dlipicar
force-pushed
the
feat/replace-old-transfer-detector
branch
3 times, most recently
from
c020188 to
bd4386a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6960 +/- ##
===========================================
+ Coverage 55.44% 59.36% +3.91%
===========================================
Files 833 822 -11
Lines 120101 116644 -3457
===========================================
+ Hits 66595 69248 +2653
+ Misses 46535 40275 -6260
- Partials 6971 7121 +150
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saledjenic
approved these changes
Oct 2, 2025
dlipicar
force-pushed
the
feat/introduce-transferdetector-package
branch
from
f046a1d to
5942ffa
Compare
dlipicar
force-pushed
the
feat/replace-old-transfer-detector
branch
from
bd4386a to
d064ce0
Compare
dlipicar
force-pushed
the
feat/introduce-transferdetector-package
branch
from
5942ffa to
b387458
Compare
dlipicar
force-pushed
the
feat/replace-old-transfer-detector
branch
from
d064ce0 to
1933ca4
Compare
dlipicar
force-pushed
the
feat/introduce-transferdetector-package
branch
3 times, most recently
from
58b92b5 to
e598c02
Compare
dlipicar
force-pushed
the
feat/replace-old-transfer-detector
branch
from
1933ca4 to
c89a9ca
Compare
Base automatically changed from
feat/introduce-transferdetector-package
to
develop
October 2, 2025 16:23
dlipicar
force-pushed
the
feat/replace-old-transfer-detector
branch
3 times, most recently
from
ba10eaa to
6b24327
Compare
vkjr
reviewed
Oct 3, 2025
vkjr
approved these changes
Oct 3, 2025
dlipicar
force-pushed
the
feat/replace-old-transfer-detector
branch
2 times, most recently
from
6637db7 to
a1c4195
Compare
…nce and transferdetector
dlipicar
force-pushed
the
feat/replace-old-transfer-detector
branch
from
a1c4195 to
c9ab1fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
status-dekstop PR for testing: status-im/status-desktop#18924
This PR removes the old transfer detection algorithm (most of
services/wallet/transfer) and integratesmultistandardbalance(#6958) andtransferdetector(#6959) instead.Additionally
blockchainstateis improved to properly initialize with the latest block number. After that,multistandardbalanceupdates it every time it performs a fetch.Modules that needed to react to detected transactions (to trigger assets/collectibles refreshes) now listen to balance changes from
multistandardbalance(multistandardbalance.EventBalanceFetchFinished) and detected transfer events fromtransferdetector(transferdetector.EventTransferDetectionFinished).Results of these changes:
multistandardbalancetransferdetectorAll ERC20/ERC721/ERC1155 transfer events (of known or unknown tokens) will be detected in 10 minute periods.