Skip to content

Conversation

micieslak
Copy link
Member

@micieslak micieslak commented Sep 24, 2025

What does the PR do

Aligns the design of asset/collectible details view to fit mobile screens.

Closes: #18206

Affected areas

AssetDetailView, CollectibleDetailsHeader and some related subcomponents

Architecture compliance

Screencapture of the functionality

Screenshot from 2025-09-24 23-20-16 Screenshot from 2025-09-24 23-21-04

Risk

Low

@micieslak micieslak requested review from a team, alexjba, caybro and noeliaSD as code owners September 24, 2025 21:38
@micieslak micieslak requested review from Khushboo-dev-cpp and removed request for a team September 24, 2025 21:38
@status-im-auto
Copy link
Member

status-im-auto commented Sep 24, 2025

Jenkins Builds

Click to see older builds (20)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5c1ce24 #1 2025-09-24 21:46:35 ~7 min tests/nim 📄log
✔️ 5c1ce24 #1 2025-09-24 21:48:50 ~9 min android/arm64 🤖apk 📲
✔️ 5c1ce24 #1 2025-09-24 21:52:16 ~13 min ios/aarch64 📦pkg
✔️ 5c1ce24 #1 2025-09-24 21:53:07 ~13 min tests/ui 📄log
✔️ 5c1ce24 #1 2025-09-24 21:54:12 ~14 min macos/aarch64 🍎dmg
✔️ 5c1ce24 #1 2025-09-24 21:56:03 ~16 min linux/x86_64 📦tgz
✔️ 5c1ce24 #1 2025-09-24 22:01:38 ~22 min macos/aarch64-nwaku 🍎dmg
✔️ 5c1ce24 #1 2025-09-24 22:02:24 ~23 min linux/x86_64-nwaku 📦tgz
✔️ 5c1ce24 #1 2025-09-24 22:09:12 ~29 min windows/x86_64 💿exe
✔️ 5c1ce24 pr18910 2025-09-24 22:10:14 ~14 min tests/e2e 📊rpt
✔️ d37f1337 #2 2025-09-25 17:25:59 ~10 min android/arm64 🤖apk 📲
✔️ 67c23826 #4 2025-09-26 23:21:59 ~6 min android/arm64 🤖apk 📲
✔️ dd02dbe #2 2025-09-26 23:22:04 ~6 min tests/nim 📄log
✔️ dd02dbe #2 2025-09-26 23:22:20 ~6 min ios/aarch64 📦pkg
✔️ dd02dbe #2 2025-09-26 23:28:17 ~12 min tests/ui 📄log
✔️ dd02dbe #2 2025-09-26 23:30:31 ~14 min macos/aarch64 🍎dmg
✔️ dd02dbe #2 2025-09-26 23:31:48 ~16 min linux/x86_64 📦tgz
✔️ dd02dbe #2 2025-09-26 23:42:44 ~26 min windows/x86_64 💿exe
✔️ dd02dbe pr18910 2025-09-26 23:46:34 ~14 min tests/e2e 📊rpt
✔️ ead14494 #5 2025-09-29 17:22:42 ~7 min android/arm64 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 26444f5 #3 2025-10-02 12:20:26 ~8 min ios/aarch64 📦pkg
✔️ 26444f5 #8 2025-10-02 12:26:22 ~14 min android/arm64 🤖apk 📲
✔️ 26444f5 #3 2025-10-02 12:27:26 ~15 min tests/nim 📄log
✔️ 26444f5 #3 2025-10-02 12:31:09 ~18 min macos/aarch64 🍎dmg
✔️ 26444f5 #3 2025-10-02 12:32:59 ~20 min macos/aarch64-nwaku 🍎dmg
✔️ 26444f5 #3 2025-10-02 12:35:27 ~22 min tests/ui 📄log
✔️ 26444f5 #3 2025-10-02 12:39:29 ~26 min windows/x86_64 💿exe
26444f5 #4 2025-10-03 15:05:54 ~32 min linux/x86_64-nwaku 📄log
26444f5 #4 2025-10-03 15:07:00 ~33 min linux/x86_64 📄log
✔️ 54b9619 #11 2025-10-06 08:07:39 ~7 min android/arm64 🤖apk 📲
✔️ 54b9619 #4 2025-10-06 08:08:22 ~8 min ios/aarch64 📦pkg
✔️ 54b9619 #4 2025-10-06 08:10:36 ~10 min tests/nim 📄log
✔️ 54b9619 #4 2025-10-06 08:18:57 ~18 min tests/ui 📄log
✔️ 54b9619 #4 2025-10-06 08:25:27 ~25 min windows/x86_64 💿exe
✔️ 54b9619 #6 2025-10-06 08:26:15 ~15 min linux/x86_64 📦tgz
✔️ 54b9619 pr18910 2025-10-06 08:42:22 ~16 min tests/e2e 📊rpt
✔️ 54b9619 #6 2025-10-06 09:13:21 ~10 min macos/aarch64 🍎dmg

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some inline comments and questions :)

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@noeliaSD noeliaSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested!! LGTM!

@micieslak micieslak requested a review from a team as a code owner October 2, 2025 12:12
@micieslak micieslak merged commit be73fd0 into master Oct 6, 2025
10 of 12 checks passed
@micieslak micieslak deleted the fix/issue-18206 branch October 6, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Mobile] Asset details / Collectible details page is cut off on mobile

4 participants