-
Notifications
You must be signed in to change notification settings - Fork 86
Wallet: asset/collectible details view adjusted for mobile #18910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jenkins BuildsClick to see older builds (20)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some inline comments and questions :)
5c1ce24
to
dd02dbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested!! LGTM!
dd02dbe
to
26444f5
Compare
26444f5
to
54b9619
Compare
What does the PR do
Aligns the design of asset/collectible details view to fit mobile screens.
Closes: #18206
Affected areas
AssetDetailView
,CollectibleDetailsHeader
and some related subcomponentsArchitecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Risk
Low