-
Notifications
You must be signed in to change notification settings - Fork 87
Community settings - responsive sizing #18899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jenkins BuildsClick to see older builds (29)
|
601413e
to
f5e064d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ui/app/AppLayouts/Communities/panels/MintTokensSettingsPanel.qml
Outdated
Show resolved
Hide resolved
Those issues are handled in another PR: #18910 |
f5e064d
to
e35fc03
Compare
e35fc03
to
2b57a3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT. Nice work!
|
||
// Token object properties: | ||
/* required */ property TokenObject token // https://bugreports.qt.io/browse/QTBUG-84269 | ||
required property TokenObject token // https://bugreports.qt.io/browse/QTBUG-84269 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the comment still relevant?
What does the PR do
This PR makes community settings fully usable on mobile/tablet and narrow screens/windows in general.
Closes: #18284
Closes: #18200
Closes: #18201
Affected areas
Community settings building blocks
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Sample screenshots:
Impact on end user
Medium
How to test
Risk