Skip to content

Conversation

micieslak
Copy link
Member

@micieslak micieslak commented Sep 23, 2025

What does the PR do

This PR makes community settings fully usable on mobile/tablet and narrow screens/windows in general.

  • fully adaptive content width
  • consistent and not overlapping location of scroll bars
  • repeated in multiple places figma-based magic values deduplicated
  • various fixes on lower-level components to present content correctly when space is limited

Closes: #18284
Closes: #18200
Closes: #18201

Affected areas

Community settings building blocks

Architecture compliance

Screencapture of the functionality

Sample screenshots:

Screenshot from 2025-09-23 15-52-32 Screenshot from 2025-09-23 15-52-18 Screenshot from 2025-09-23 15-51-51 Screenshot from 2025-09-23 15-51-23 Screenshot from 2025-09-23 15-51-08 Screenshot from 2025-09-23 15-51-04

Impact on end user

Medium

How to test

  • Perform actions related to community management, including minting tokens and airdrops

Risk

@micieslak micieslak requested review from a team, alexjba, caybro and noeliaSD as code owners September 23, 2025 14:34
@micieslak micieslak marked this pull request as draft September 23, 2025 14:34
@status-im-auto
Copy link
Member

status-im-auto commented Sep 23, 2025

Jenkins Builds

Click to see older builds (29)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 601413e #1 2025-09-23 14:42:18 ~7 min tests/nim 📄log
✔️ 601413e #1 2025-09-23 14:44:15 ~9 min android/arm64 🤖apk 📲
✔️ 601413e #1 2025-09-23 14:48:05 ~12 min tests/ui 📄log
✔️ 601413e #1 2025-09-23 14:48:07 ~13 min ios/aarch64 📦pkg
✔️ f5e064d #2 2025-09-23 14:54:18 ~5 min tests/nim 📄log
✔️ f5e064d #2 2025-09-23 14:54:51 ~6 min android/arm64 🤖apk 📲
✔️ f5e064d #2 2025-09-23 14:58:46 ~10 min ios/aarch64 📦pkg
✔️ f5e064d #2 2025-09-23 15:01:37 ~13 min macos/aarch64 🍎dmg
✔️ f5e064d #2 2025-09-23 15:01:45 ~13 min tests/ui 📄log
✔️ f5e064d #2 2025-09-23 15:04:23 ~15 min linux/x86_64 📦tgz
✔️ f5e064d #2 2025-09-23 15:07:37 ~19 min macos/aarch64-nwaku 🍎dmg
✔️ f5e064d #2 2025-09-23 15:10:42 ~22 min windows/x86_64 💿exe
✔️ f5e064d #2 2025-09-23 15:10:55 ~22 min linux/x86_64-nwaku 📦tgz
✔️ f5e064d pr18899 2025-09-23 15:18:15 ~13 min tests/e2e 📊rpt
✔️ 2a6ba567 #3 2025-09-24 17:25:18 ~9 min android/arm64 🤖apk 📲
✔️ 0ec49868 #5 2025-09-26 17:23:16 ~7 min android/arm64 🤖apk 📲
✔️ 02854f16 #6 2025-09-26 23:35:14 ~6 min android/arm64 🤖apk 📲
✔️ e35fc03 #3 2025-09-26 23:36:42 ~8 min tests/nim 📄log
✔️ e9579c04 #7 2025-09-26 23:43:55 ~6 min android/arm64 🤖apk 📲
✔️ 2b57a3a #4 2025-09-26 23:46:04 ~8 min tests/nim 📄log
✔️ 2b57a3a #4 2025-09-26 23:48:40 ~11 min ios/aarch64 📦pkg
✔️ 2b57a3a #4 2025-09-26 23:50:59 ~13 min tests/ui 📄log
✔️ 2b57a3a #4 2025-09-26 23:53:40 ~15 min macos/aarch64 🍎dmg
✔️ 2b57a3a #4 2025-09-26 23:54:42 ~17 min linux/x86_64 📦tgz
✔️ 2b57a3a #4 2025-09-26 23:58:30 ~20 min windows/x86_64 💿exe
✔️ 2b57a3a #4 2025-09-26 23:59:10 ~21 min macos/aarch64-nwaku 🍎dmg
✔️ 2b57a3a #4 2025-09-27 00:00:20 ~22 min linux/x86_64-nwaku 📦tgz
✔️ 2b57a3a pr18899 2025-09-27 00:08:35 ~13 min tests/e2e 📊rpt
✔️ 28be7bcb #8 2025-09-29 17:27:12 ~11 min android/arm64 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 40656c0a #10 2025-10-01 17:22:43 ~7 min android/arm64 🤖apk 📲
✔️ e956a71b #11 2025-10-02 17:22:58 ~7 min android/arm64 🤖apk 📲

@micieslak micieslak marked this pull request as ready for review September 23, 2025 14:51
Copy link
Contributor

@noeliaSD noeliaSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

  • All Community Settings pages are now nicely displayed.
  • I've just added some suggestions.
  • I still see the wallet activity info box overflowing and the collectibles info box truncated!
Screenshot 2025-09-26 at 12 50 32 Screenshot 2025-09-26 at 12 50 27

@micieslak
Copy link
Member Author

micieslak commented Sep 26, 2025

Code LGTM!

  • All Community Settings pages are now nicely displayed.
  • I've just added some suggestions.
  • I still see the wallet activity info box overflowing and the collectibles info box truncated!

Screenshot 2025-09-26 at 12 50 32 Screenshot 2025-09-26 at 12 50 27

Those issues are handled in another PR: #18910

Copy link
Contributor

@noeliaSD noeliaSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! LGTM!

Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Nice work!


// Token object properties:
/* required */ property TokenObject token // https://bugreports.qt.io/browse/QTBUG-84269
required property TokenObject token // https://bugreports.qt.io/browse/QTBUG-84269
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment still relevant?

@micieslak micieslak merged commit b05c576 into master Oct 3, 2025
12 checks passed
@micieslak micieslak deleted the responsive-sizing branch October 3, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants