Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KeyboardShortcuts.md #5615

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+31 −9
Open

Update KeyboardShortcuts.md #5615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 31 additions & 9 deletions ui/v2.5/src/docs/en/Manual/KeyboardShortcuts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@
| `,` | Hide/Show sidebar |
| `.` | Hide/Show scene scrubber |
| `o` | Increment O-Counter |
| Ratings ||
| `r {1-5}` | Set rating (stars) |
| `r 0` | Unset rating (stars) |
| `r {0-9} {0-9}` | Set rating (decimal - `00` for `10.0`) |
| ``r ` `` | Unset rating (decimal) |
| Playback ||
| `p n` | Play next scene in queue |
| `p p` | Play previous scene in queue |
| `p r` | Play random scene in queue |
Expand All @@ -88,14 +94,10 @@
|-------------------|--------|
| `n` | Display Create Markers dialog |

### Edit Scene tab shortcuts
### Scene Edit tab shortcuts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now makes it inconsistent with other headers. It should either be kept as it was or all of them should be updated.


| Keyboard sequence | Action |
|-------------------|--------|
| `r {1-5}` | Set rating (stars) |
| `r 0` | Unset rating (stars) |
| `r {0-9} {0-9}` | Set rating (decimal - `00` for `10.0`) |
| ``r ` `` | Unset rating (decimal) |
| `s s` | Save Scene |
| `d d` | Delete Scene |
| `Ctrl + v` | Paste Scene cover |
Expand All @@ -107,6 +109,25 @@
[//]: # "(| `v` | Focus Groups selector |)"
[//]: # "(| `t` | Focus Tags selector |)"

## Image Page shortcuts

| Keyboard sequence | Action |
|-------------------|--------|
| `e` | Edit tab |
| `o` | Increment O-Counter |
| Ratings ||
| `r {1-5}` | Set rating (stars) |
| `r 0` | Unset rating (stars) |
| `r {0-9} {0-9}` | Set rating (decimal - `00` for `10.0`) |
| ``r ` `` | Unset rating (decimal) |

### Image Edit tab shortcuts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inconsistent with other headers. It should match the others or all of them should be updated.


| Keyboard sequence | Action |
|-------------------|--------|
| `s s` | Save Scene |
| `d d` | Delete Scene |

## Groups Page shortcuts

| Keyboard sequence | Action |
Expand All @@ -120,12 +141,13 @@
| `e` | Edit Group |
| `s s` | Save Group |
| `d d` | Delete Group |
| `r {1-5}` | [Edit mode] Set rating (stars) |
| `r 0` | [Edit mode] Unset rating (stars) |
| `r {0-9} {0-9}` | [Edit mode] Set rating (decimal - `r 0 0` for `10.0`) |
| ``r ` `` | [Edit mode] Unset rating (decimal) |
| `,` | Expand/Collapse Details |
| `Ctrl + v` | Paste Group image |
| Ratings ||
| `r {1-5}` | [Edit mode] Set rating (stars) |
| `r 0` | [Edit mode] Unset rating (stars) |
| `r {0-9} {0-9}` | [Edit mode] Set rating (decimal - `r 0 0` for `10.0`) |
Comment on lines +147 to +150
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to move this section (including line 144) under a new header Edit Groups tab shortcuts and stripping [Edit mode] from the action name.

There is a technical issue where the only way to trigger rating shortcuts is by entering edit mode or rating something manually, after that they will work outside edit mode too.

But I noticed some other inconsistent behavior with some other shortcuts, so it probably needs more in-depth review at some point, I'll approve the PR without this change.


[//]: # "Commented until implementation is dealt with"
[//]: # "(| `u` | Focus Studio selector (in edit mode) |)"
Expand Down Expand Up @@ -191,4 +213,4 @@
| `s s` | Save Tag |
| `d d` | Delete Tag |
| `,` | Expand/Collapse Details |
| `Ctrl + v` | Paste Tag image |
| `Ctrl + v` | Paste Tag image |
Loading