Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KeyboardShortcuts.md #5615

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

echo6ix
Copy link
Contributor

@echo6ix echo6ix commented Jan 20, 2025

  • Added table of shortcuts for Image page
  • Reorganized a few tables to include sub-headings
  • Renamed Edit Scene tab [...] heading to Scene Edit tab [...] for logical consistency with other headings
  • Moved Scene page rating shortcuts from vestigial location in Edit Scene section to global Scene page section

- Added table of shortcuts for Image page
- Reorganized a few tables to include sub-headings
- Renamed `Edit Scene tab [...]` heading to `Scene Edit tab [...]` for logical consistency with other headings
- Moved Scene page rating shortcuts from vestigial location in *Edit Scene* section to global Scene page section
@@ -88,14 +94,10 @@
|-------------------|--------|
| `n` | Display Create Markers dialog |

### Edit Scene tab shortcuts
### Scene Edit tab shortcuts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now makes it inconsistent with other headers. It should either be kept as it was or all of them should be updated.

| `r {0-9} {0-9}` | Set rating (decimal - `00` for `10.0`) |
| ``r ` `` | Unset rating (decimal) |

### Image Edit tab shortcuts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inconsistent with other headers. It should match the others or all of them should be updated.

Comment on lines +147 to +150
| Ratings ||
| `r {1-5}` | [Edit mode] Set rating (stars) |
| `r 0` | [Edit mode] Unset rating (stars) |
| `r {0-9} {0-9}` | [Edit mode] Set rating (decimal - `r 0 0` for `10.0`) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to move this section (including line 144) under a new header Edit Groups tab shortcuts and stripping [Edit mode] from the action name.

There is a technical issue where the only way to trigger rating shortcuts is by entering edit mode or rating something manually, after that they will work outside edit mode too.

But I noticed some other inconsistent behavior with some other shortcuts, so it probably needs more in-depth review at some point, I'll approve the PR without this change.

@DogmaDragon DogmaDragon added the documentation Instructions and support material label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Instructions and support material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants