Skip to content

added specialization for recursive functions #8881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomerStarkware merged 2 commits into from
Dec 14, 2025
+6,872 −5,351
Merged

added specialization for recursive functions #8881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0aaf57f
canonicalize specilize args to always use SpecializationArg::Struct/Enum
TomerStarkware Dec 10, 2025
fdbbc36
added specialization for recursive functions
TomerStarkware Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 44 additions & 3 deletions crates/cairo-lang-lowering/src/lower/generated_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,16 @@ use cairo_lang_defs::ids::TopLevelLanguageElementId;
use cairo_lang_filesystem::location_marks::get_location_marks;
use cairo_lang_semantic::test_utils::setup_test_function;
use cairo_lang_test_utils::parse_test_file::TestRunnerResult;
use cairo_lang_utils::Intern;
use cairo_lang_utils::ordered_hash_map::OrderedHashMap;
use cairo_lang_utils::{Intern, try_extract_matches};

use crate::LoweringStage;
use crate::db::LoweringGroup;
use crate::fmt::LoweredFormatter;
use crate::ids::{ConcreteFunctionWithBodyId, ConcreteFunctionWithBodyLongId, GeneratedFunction};
use crate::ids::{
ConcreteFunctionWithBodyId, ConcreteFunctionWithBodyLongId, FunctionLongId, GeneratedFunction,
};
use crate::test_utils::LoweringDatabaseForTesting;
use crate::{LoweringStage, Statement};

cairo_lang_test_utils::test_file_test!(
generated,
Expand Down Expand Up @@ -58,6 +60,34 @@ fn test_generated_function(
lowering.debug(&LoweredFormatter::new(db, &lowering.variables))
)
.unwrap();
// Collect the calls to the generated functions in the final lowering of the main function.
let calls = lowering
.blocks
.iter()
.flat_map(|(_, block)| {
block
.statements
.iter()
.filter_map(|statement| try_extract_matches!(statement, Statement::Call))
})
.flat_map(|call| match call.function.long(db) {
FunctionLongId::Semantic(_) => None,
FunctionLongId::Generated(generated) => Some((
generated.key,
ConcreteFunctionWithBodyLongId::Generated(*generated).intern(db),
)),
FunctionLongId::Specialized(specialized) => try_extract_matches!(
specialized.base.function_id(db).unwrap().long(db),
FunctionLongId::Generated
)
.map(|generated| {
(
generated.key,
ConcreteFunctionWithBodyLongId::Specialized(specialized.clone()).intern(db),
)
}),
})
.collect::<OrderedHashMap<_, _>>();

for (key, lowering) in multi_lowering.generated_lowerings.iter() {
let generated_id = ConcreteFunctionWithBodyLongId::Generated(GeneratedFunction {
Expand Down Expand Up @@ -97,6 +127,17 @@ fn test_generated_function(
lowering.debug(&LoweredFormatter::new(db, &lowering.variables))
)
.unwrap();

if let Some(call) = calls.get(key) {
let lowering = db.lowered_body(*call, LoweringStage::Final).unwrap();
writeln!(
&mut writer,
"Final lowering of specialized call {:?}:\n{:?}",
call.full_path(db),
lowering.debug(&LoweredFormatter::new(db, &lowering.variables))
)
.unwrap();
}
}
}

Expand Down
145 changes: 122 additions & 23 deletions crates/cairo-lang-lowering/src/lower/test_data/for
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,41 +52,39 @@ Final lowering:
Parameters: v0: core::RangeCheck, v1: core::gas::GasBuiltin
blk0 (root):
Statements:
(v2: core::felt252) <- 1
(v3: core::felt252) <- 2
(v4: core::array::Array::<core::felt252>) <- core::array::array_new::<core::felt252>()
(v5: core::felt252) <- 10
(v2: core::array::Array::<core::felt252>) <- core::array::array_new::<core::felt252>()
(v3: core::felt252) <- 10
(v4: core::array::Array::<core::felt252>) <- core::array::array_append::<core::felt252>(v2, v3)
(v5: core::felt252) <- 11
(v6: core::array::Array::<core::felt252>) <- core::array::array_append::<core::felt252>(v4, v5)
(v7: core::felt252) <- 11
(v7: core::felt252) <- 12
(v8: core::array::Array::<core::felt252>) <- core::array::array_append::<core::felt252>(v6, v7)
(v9: core::felt252) <- 12
(v9: core::felt252) <- 13
(v10: core::array::Array::<core::felt252>) <- core::array::array_append::<core::felt252>(v8, v9)
(v11: core::felt252) <- 13
(v12: core::array::Array::<core::felt252>) <- core::array::array_append::<core::felt252>(v10, v11)
(v13: core::array::Array::<core::felt252>, v14: @core::array::Array::<core::felt252>) <- snapshot(v12)
(v15: core::array::Span::<core::felt252>) <- struct_construct(v14)
(v16: core::array::SpanIter::<core::felt252>) <- struct_construct(v15)
(v17: core::RangeCheck, v18: core::gas::GasBuiltin, v19: core::panics::PanicResult::<(core::array::SpanIter::<core::felt252>, core::felt252, ())>) <- test::foo[118-164](v0, v1, v16, v2, v3)
End:
Match(match_enum(v19) {
PanicResult::Ok(v20) => blk1,
PanicResult::Err(v21) => blk2,
(v11: core::array::Array::<core::felt252>, v12: @core::array::Array::<core::felt252>) <- snapshot(v10)
(v13: core::array::Span::<core::felt252>) <- struct_construct(v12)
(v14: core::array::SpanIter::<core::felt252>) <- struct_construct(v13)
(v15: core::RangeCheck, v16: core::gas::GasBuiltin, v17: core::panics::PanicResult::<(core::array::SpanIter::<core::felt252>, core::felt252, ())>) <- test::foo[118-164]{NotSpecialized, 1, 2, }(v0, v1, v14)
End:
Match(match_enum(v17) {
PanicResult::Ok(v18) => blk1,
PanicResult::Err(v19) => blk2,
})

blk1:
Statements:
(v22: core::gas::GasBuiltin) <- core::gas::redeposit_gas(v18)
(v23: core::array::SpanIter::<core::felt252>, v24: core::felt252, v25: ()) <- struct_destructure(v20)
(v26: (core::felt252,)) <- struct_construct(v24)
(v27: core::panics::PanicResult::<(core::felt252,)>) <- PanicResult::Ok(v26)
(v20: core::gas::GasBuiltin) <- core::gas::redeposit_gas(v16)
(v21: core::array::SpanIter::<core::felt252>, v22: core::felt252, v23: ()) <- struct_destructure(v18)
(v24: (core::felt252,)) <- struct_construct(v22)
(v25: core::panics::PanicResult::<(core::felt252,)>) <- PanicResult::Ok(v24)
End:
Return(v17, v22, v27)
Return(v15, v20, v25)

blk2:
Statements:
(v28: core::panics::PanicResult::<(core::felt252,)>) <- PanicResult::Err(v21)
(v26: core::panics::PanicResult::<(core::felt252,)>) <- PanicResult::Err(v19)
End:
Return(v17, v18, v28)
Return(v15, v16, v26)


Generated loop lowering for source location:
Expand Down Expand Up @@ -168,6 +166,56 @@ Statements:
End:
Return(v7, v8, v28)


Final lowering of specialized call "test::foo[118-164]{NotSpecialized, 1, 2, }":
Parameters: v0: core::RangeCheck, v1: core::gas::GasBuiltin, v2: core::array::SpanIter::<core::felt252>
blk0 (root):
Statements:
End:
Match(match core::gas::withdraw_gas(v0, v1) {
Option::Some(v3, v4) => blk1,
Option::None(v5, v6) => blk4,
})

blk1:
Statements:
(v7: core::array::Span::<core::felt252>) <- struct_destructure(v2)
(v8: @core::array::Array::<core::felt252>) <- struct_destructure(v7)
End:
Match(match core::array::array_snapshot_pop_front::<core::felt252>(v8) {
Option::Some(v9, v10) => blk2,
Option::None(v11) => blk3,
})

blk2:
Statements:
(v12: core::gas::GasBuiltin) <- core::gas::redeposit_gas(v4)
(v13: core::felt252) <- 3
(v14: core::array::Span::<core::felt252>) <- struct_construct(v9)
(v15: core::array::SpanIter::<core::felt252>) <- struct_construct(v14)
(v16: core::RangeCheck, v17: core::gas::GasBuiltin, v18: core::panics::PanicResult::<(core::array::SpanIter::<core::felt252>, core::felt252, ())>) <- test::foo[118-164]{NotSpecialized, NotSpecialized, 2, }(v3, v12, v15, v13)
End:
Return(v16, v17, v18)

blk3:
Statements:
(v19: core::gas::GasBuiltin) <- core::gas::redeposit_gas(v4)
(v20: core::felt252) <- 1
(v21: core::array::Span::<core::felt252>) <- struct_construct(v11)
(v22: core::array::SpanIter::<core::felt252>) <- struct_construct(v21)
(v23: ()) <- struct_construct()
(v24: (core::array::SpanIter::<core::felt252>, core::felt252, ())) <- struct_construct(v22, v20, v23)
(v25: core::panics::PanicResult::<(core::array::SpanIter::<core::felt252>, core::felt252, ())>) <- PanicResult::Ok(v24)
End:
Return(v3, v19, v25)

blk4:
Statements:
(v26: (core::panics::Panic, core::array::Array::<core::felt252>)) <- core::panic_with_const_felt252::<375233589013918064796019>()
(v27: core::panics::PanicResult::<(core::array::SpanIter::<core::felt252>, core::felt252, ())>) <- PanicResult::Err(v26)
End:
Return(v5, v6, v27)

//! > ==========================================================================

//! > Test calling function with generics Self.
Expand Down Expand Up @@ -420,3 +468,54 @@ Statements:
(v29: core::panics::PanicResult::<(core::array::SpanIter::<core::felt252>, core::array::Array::<core::felt252>, ())>) <- PanicResult::Err(v28)
End:
Return(v6, v7, v29)


Final lowering of specialized call "test::foo[78-125]":
Parameters: v0: core::RangeCheck, v1: core::gas::GasBuiltin, v2: core::array::SpanIter::<core::felt252>, v3: core::array::Array::<core::felt252>
blk0 (root):
Statements:
End:
Match(match core::gas::withdraw_gas(v0, v1) {
Option::Some(v4, v5) => blk1,
Option::None(v6, v7) => blk4,
})

blk1:
Statements:
(v8: core::array::Span::<core::felt252>) <- struct_destructure(v2)
(v9: @core::array::Array::<core::felt252>) <- struct_destructure(v8)
End:
Match(match core::array::array_snapshot_pop_front::<core::felt252>(v9) {
Option::Some(v10, v11) => blk2,
Option::None(v12) => blk3,
})

blk2:
Statements:
(v13: core::gas::GasBuiltin) <- core::gas::redeposit_gas(v5)
(v14: @core::felt252) <- core::box::unbox::<@core::felt252>(v11)
(v15: core::felt252) <- desnap(v14)
(v16: core::array::Array::<core::felt252>) <- core::array::array_append::<core::felt252>(v3, v15)
(v17: core::array::Span::<core::felt252>) <- struct_construct(v10)
(v18: core::array::SpanIter::<core::felt252>) <- struct_construct(v17)
(v19: core::RangeCheck, v20: core::gas::GasBuiltin, v21: core::panics::PanicResult::<(core::array::SpanIter::<core::felt252>, core::array::Array::<core::felt252>, ())>) <- test::foo[78-125](v4, v13, v18, v16)
End:
Return(v19, v20, v21)

blk3:
Statements:
(v22: core::gas::GasBuiltin) <- core::gas::redeposit_gas(v5)
(v23: core::array::Span::<core::felt252>) <- struct_construct(v12)
(v24: core::array::SpanIter::<core::felt252>) <- struct_construct(v23)
(v25: ()) <- struct_construct()
(v26: (core::array::SpanIter::<core::felt252>, core::array::Array::<core::felt252>, ())) <- struct_construct(v24, v3, v25)
(v27: core::panics::PanicResult::<(core::array::SpanIter::<core::felt252>, core::array::Array::<core::felt252>, ())>) <- PanicResult::Ok(v26)
End:
Return(v4, v22, v27)

blk4:
Statements:
(v28: (core::panics::Panic, core::array::Array::<core::felt252>)) <- core::panic_with_const_felt252::<375233589013918064796019>()
(v29: core::panics::PanicResult::<(core::array::SpanIter::<core::felt252>, core::array::Array::<core::felt252>, ())>) <- PanicResult::Err(v28)
End:
Return(v6, v7, v29)
Loading