added specialization for recursive functions

[TomerStarkware]

TL;DR

Improve function specialization in the lowering phase by tracking specialized function calls

What changed?

• Enhanced the const folding mechanism to handle recursive specialization more intelligently

[reviewable-StarkWare]

This change is 

[TomerStarkware]

• added specialization for recursive functions #8881 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[orizi]

@orizi reviewed 1 of 6 files at r1, all commit messages.
Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

---

crates/cairo-lang-lowering/src/lower/generated_test.rs line 69 at r1 (raw file):

        )
        .unwrap();
        let calls = lowering

doc what you are doing here.

[orizi]

@orizi reviewed 1 of 6 files at r1, 7 of 8 files at r2.
Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 719 at r2 (raw file):

                }
                _ => vec![None; call_stmt.inputs.len()],
            };

Suggestion:

        let self_specializition =
            if let ConcreteFunctionWithBodyLongId::Specialized(specialized) = self.caller_function &&
             caller_base == called_base {
                specialized.args.iter().map(Some).collect()
            } else {
                vec![None; call_stmt.inputs.len()]
            };

[orizi]

Reviewable status: 8 of 9 files reviewed, 2 unresolved discussions (waiting on @TomerStarkware)

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 1330 at r2 (raw file):

        ty: TypeId<'db>,
        unknown_vars: &mut Vec<VarUsage<'db>>,
        coerce: Option<&SpecializationArg<'db>>,

add doc about the coercion.

[orizi]

@orizi reviewed 1 of 8 files at r2, all commit messages.
Reviewable status: 9 of 11 files reviewed, 3 unresolved discussions (waiting on @TomerStarkware)

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 1455 at r3 (raw file):

                            unreachable!("Expected an enum specialization argument");
                        };
                        assert_eq!(coercion_variant, &variant);

shouldn't this just return None?

Code quote:

                        assert_eq!(coercion_variant, &variant);

[orizi]

@orizi reviewed 10 of 10 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @TomerStarkware)

[orizi]

@orizi reviewed 3 of 8 files at r5, all commit messages.
Reviewable status: 6 of 11 files reviewed, 2 unresolved discussions (waiting on @TomerStarkware)

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 1423 at r5 (raw file):

                    Some(coerce) => {
                        let SpecializationArg::Struct(specialization_args) = coerce else {
                            unreachable!("Expected a struct specialization argument");

reachable ::Const as well.

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 1457 at r5 (raw file):

                        let SpecializationArg::Enum { variant: coercion_variant, payload } = coerce
                        else {
                            unreachable!("Expected an enum specialization argument");

reachable ::Const as well.

[orizi]

@orizi reviewed 4 of 8 files at r5, 8 of 8 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

[TomerStarkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

---

crates/cairo-lang-lowering/src/lower/generated_test.rs line 69 at r1 (raw file):

Previously, orizi wrote…

doc what you are doing here.

Done.

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 1330 at r2 (raw file):

Previously, orizi wrote…

add doc about the coercion.

Done.

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 1455 at r3 (raw file):

Previously, orizi wrote…

shouldn't this just return None?

Done.

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 1457 at r5 (raw file):

Previously, orizi wrote…

reachable ::Const as well.

changed in previous pr

---

crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 719 at r2 (raw file):

                }
                _ => vec![None; call_stmt.inputs.len()],
            };

Done.

[orizi]

@orizi reviewed 7 of 7 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)