Affine coordinate are not correctly exposed from the underlying type. #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilipLaurentiu
requested review from
pefontana and
dan-starkware
as code owners
ProjectivePoints have 3 coordinates (x,y,z) and the AffinePoint incorrectly expose just the (x, y) coordinate without converting the representation from projective to affine.
tdelabro
reviewed
Jan 29, 2025
|
@tdelabro any updates on this pr ? |
tdelabro
approved these changes
Feb 11, 2025
gabrielbosio
approved these changes
Mar 10, 2025
pefontana
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProjectivePoints have 3 coordinates (x,y,z) and the AffinePoint incorrectly expose just the (x, y) coordinate without converting the representation from projective to affine.
Pull Request type
What is the current behavior?
Affine coordinate are not correctly exposed from the underlying type.
What is the new behavior?
AffinePoint convert the ProjectivePoint coordinate to the affine coordinate and then extract the coordinates
Does this introduce a breaking change?
No
Other information
The problem appear when points are multiplied/added together and the
zcoordinate of the projective representation change.