Affine coordinate are not correctly exposed from the underlying type.

FilipLaurentiu · FilipLaurentiu · commit 110fa284922b · 2025-01-29T12:02:32.000+02:00
ProjectivePoints have 3 coordinates (x,y,z) and the AffinePoint incorrectly expose just the (x, y) coordinate without converting the representation from projective to affine.
diff --git a/crates/starknet-types-core/src/curve/affine_point.rs b/crates/starknet-types-core/src/curve/affine_point.rs
@@ -44,12 +44,12 @@ impl AffinePoint {
 
     /// Returns the `x` coordinate of the point.
     pub fn x(&self) -> Felt {
-        Felt(*self.0.x())
+        Felt(*self.0.to_affine().x())
     }
 
     /// Returns the `y` coordinate of the point.
     pub fn y(&self) -> Felt {
-        Felt(*self.0.y())
+        Felt(*self.0.to_affine().y())
     }
 
     // Returns the generator point of the StarkCurve

Original file line number	Diff line number	Diff line change
`@@ -44,12 +44,12 @@ impl AffinePoint {`
`44`	`44`
`45`	`45`	/// Returns the `x` coordinate of the point.
`46`	`46`	`pub fn x(&self) -> Felt {`
`47`		`- Felt(*self.0.x())`
	`47`	`+ Felt(*self.0.to_affine().x())`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	/// Returns the `y` coordinate of the point.
`51`	`51`	`pub fn y(&self) -> Felt {`
`52`		`- Felt(*self.0.y())`
	`52`	`+ Felt(*self.0.to_affine().y())`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`// Returns the generator point of the StarkCurve`