Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use Vec::with_capacity avoid realloc mem #101

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: use Vec::with_capacity avoid realloc mem #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d6ea73
test: use Vec::with_capacity avoid realloc mem
nkysg Oct 31, 2024
7254cbf
update review content
nkysg Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/starknet-types-core/src/felt/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,10 +1076,11 @@ mod test {
// Helper function to generate a vector of bits for testing purposes
fn generate_be_bits(x: &Felt) -> Vec<bool> {
// Initialize an empty vector to store the expected bits
let mut bits = Vec::new();
let representative = x.0.representative();
let mut bits = Vec::with_capacity(limbs.len() * 8 * 8);

// Iterate over each limb in the representative of x
for limb in x.0.representative().limbs {
for limb in bits.limbs {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't compile

// Convert the limb to a sequence of 8 bytes (u8) in big-endian
let bytes = limb.to_be_bytes();

Expand Down
Loading